Bug 106762

Summary:

Implement matching by the voice attribute for WebVTT ::cue pseudo element

Product:

WebKit

Reporter:

Dima Gorbik <dgorbik>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, feature-media-reviews, koivisto, ojan.autocc, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

105481

Bug Blocks:

43668

Attachments:

Description	Flags
Proposed fix 0.1	eric.carlson: review+
Proposed fix 0.2	none

Description Dima Gorbik 2013-01-14 00:35:51 PST

Voice elements should be able to be styles by a voice attribute. Example: ::cue(v[voice="Mark"]). For a DOM tree a voice element should be represented with a span and have a title argument set to match WebVTT voice attribute.

Comment 1 Dima Gorbik 2013-01-14 01:05:28 PST

Created attachment 182521 [details]
Proposed fix 0.1

Comment 2 Dima Gorbik 2013-01-15 14:34:44 PST

Created attachment 182848 [details]
Proposed fix 0.2

Comment 3 Radar WebKit Bug Importer 2013-01-15 15:28:01 PST

<rdar://problem/13019788>

Comment 4 WebKit Review Bot 2013-01-15 15:50:56 PST

Comment on attachment 182848 [details]
Proposed fix 0.2

Clearing flags on attachment: 182848

Committed r139803: <http://trac.webkit.org/changeset/139803>

Comment 5 WebKit Review Bot 2013-01-15 15:51:00 PST

All reviewed patches have been landed.  Closing bug.