Bug 106504

Summary: REGRESSION(r139189): pixel alignment must be performed in device units.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: Layout and RenderingAssignee: Dongseong Hwang <dongseong.hwang>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, kenneth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 106355, 106499    
Bug Blocks:    
Attachments:
Description Flags
Patch
kenneth: review+, kenneth: commit-queue-
Patch none

Dongseong Hwang
Reported 2013-01-09 16:53:17 PST
After r139189, pixel alignment is performed in UI units. If deviceScaleFactor is fractional number, adjusted scroll position can blur non-composited layer.
Attachments
Patch (2.29 KB, patch)
2013-01-09 16:59 PST, Dongseong Hwang 		kenneth: review+
kenneth: commit-queue-
DetailsFormatted DiffDiff
Patch (2.21 KB, patch)
2013-01-10 00:52 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2013-01-09 16:59:19 PST
Created attachment 182016 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2013-01-09 19:14:25 PST
Comment on attachment 182016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182016&action=review > Source/WebKit2/UIProcess/PageViewportController.cpp:98 > + float contentsScale = m_pageScaleFactor * deviceScaleFactor(); lets call this effectiveScale
Dongseong Hwang
Comment 3 2013-01-10 00:52:55 PST
Created attachment 182082 [details] Patch
WebKit Review Bot
Comment 4 2013-01-10 02:01:09 PST
Comment on attachment 182082 [details] Patch Clearing flags on attachment: 182082 Committed r139300: <http://trac.webkit.org/changeset/139300>
WebKit Review Bot
Comment 5 2013-01-10 02:01:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.