|Summary:||[GTK] Volume button should not be shown for videos without audio|
|Product:||WebKit||Reporter:||Halton Huo <halton.huo>|
|Severity:||Normal||CC:||calvaris, joone, pnormand, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description Halton Huo 2013-01-09 03:11:38 PST
With code trunk@138776, test LayoutTests/media/video-no-audio.html, the volume control will shown which is not expected. The same thing need to be done as EFL bug #97574.
Comment 2 Philippe Normand 2013-01-11 03:58:30 PST
The controls are being reworked in bug 83869. Not sure this patch makes sense meanwhile. Xabier, what do you think?
Comment 3 Xabier Rodríguez Calvar 2013-01-11 10:36:23 PST
I talked to Jon Mccann and he says that the best would be showing the mute icon and show a "no audio" tooltip when hovering the button. So I guess this will be deeply reworked. I guess it will still take some time until we finish the controls, so we could push it as a temporary solution if it does not break any test, of course.
Comment 4 Halton Huo 2013-01-13 20:52:43 PST
trunk@139575 still can not pass media/video-no-audio.html, while PASS with patch #181888.
Comment 5 Philippe Normand 2013-01-13 23:46:28 PST
Are you sure no rebaseline of the test is needed?
Comment 6 Halton Huo 2013-01-15 18:30:32 PST
(In reply to comment #5) > Are you sure no rebaseline of the test is needed? Just conflict on WebCore/GNUmakefile.list.am, easy to resolve. Actually with patch for bug 83869, the DumpRenderTree will crash when run-webkit-tests LayoutTests/media/video-no-audio.html, but PASS with run-launcher.
Comment 7 Xabier Rodríguez Calvar 2013-01-15 23:41:27 PST
(In reply to comment #6) > (In reply to comment #5) > > Are you sure no rebaseline of the test is needed? > Just conflict on WebCore/GNUmakefile.list.am, easy to resolve. > > Actually with patch for bug 83869, the DumpRenderTree will crash when run-webkit-tests LayoutTests/media/video-no-audio.html, but PASS with run-launcher. Patch for bug 83869 is under high development, so you cannot trust it yet.
Comment 8 Halton Huo 2013-01-15 23:51:18 PST
(In reply to comment #7) > Patch for bug 83869 is under high development, so you cannot trust it yet. Yes, I know, Philippe's comment made me to try whether the working bug 83869 will fix or hide this bug. I just give my try.
Comment 9 Halton Huo 2013-01-20 21:54:31 PST
Ping, anyone could continue review on it?
Comment 10 WebKit Review Bot 2013-01-21 08:41:01 PST
Comment on attachment 181888 [details] Patch Clearing flags on attachment: 181888 Committed r140339: <http://trac.webkit.org/changeset/140339>
Comment 11 WebKit Review Bot 2013-01-21 08:41:05 PST
All reviewed patches have been landed. Closing bug.