Summary: | [GTK] Volume button should not be shown for videos without audio | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Halton Huo <halton.huo> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | calvaris, joone, pnormand, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Halton Huo
2013-01-09 03:11:38 PST
Created attachment 181888 [details]
Patch
The controls are being reworked in bug 83869. Not sure this patch makes sense meanwhile. Xabier, what do you think? I talked to Jon Mccann and he says that the best would be showing the mute icon and show a "no audio" tooltip when hovering the button. So I guess this will be deeply reworked. I guess it will still take some time until we finish the controls, so we could push it as a temporary solution if it does not break any test, of course. trunk@139575 still can not pass media/video-no-audio.html, while PASS with patch #181888. Are you sure no rebaseline of the test is needed? (In reply to comment #5) > Are you sure no rebaseline of the test is needed? Just conflict on WebCore/GNUmakefile.list.am, easy to resolve. Actually with patch for bug 83869, the DumpRenderTree will crash when run-webkit-tests LayoutTests/media/video-no-audio.html, but PASS with run-launcher. (In reply to comment #6) > (In reply to comment #5) > > Are you sure no rebaseline of the test is needed? > Just conflict on WebCore/GNUmakefile.list.am, easy to resolve. > > Actually with patch for bug 83869, the DumpRenderTree will crash when run-webkit-tests LayoutTests/media/video-no-audio.html, but PASS with run-launcher. Patch for bug 83869 is under high development, so you cannot trust it yet. (In reply to comment #7) > Patch for bug 83869 is under high development, so you cannot trust it yet. Yes, I know, Philippe's comment made me to try whether the working bug 83869 will fix or hide this bug. I just give my try. Ping, anyone could continue review on it? Comment on attachment 181888 [details] Patch Clearing flags on attachment: 181888 Committed r140339: <http://trac.webkit.org/changeset/140339> All reviewed patches have been landed. Closing bug. |