Bug 106408

Summary: Change semantics of subtracting one Int/FloatPoint from another
Product: WebKit Reporter: Steve Block <steveblock>
Component: New BugsAssignee: Steve Block <steveblock>
Status: RESOLVED WONTFIX    
Severity: Normal CC: aboxhall, andersca, apinheiro, cfleizach, cmarcelo, dino, dmazzoni, d-r, eric, fmalita, gyuyoung.kim, jamesr, jdiggs, junov, macpherson, menard, mifenton, noam, ojan.autocc, pdr, philn, rakuco, schenney, senorblanco, simon.fraser, steveblock, tkent, tonikitoo, webkit-ews, webkit.review.bot, xan.lopez, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch buildbot: commit-queue-

Description Steve Block 2013-01-08 19:37:33 PST 
Change semantics of subtracting one Int/FloatPoint from another
Comment 1 Steve Block 2013-01-08 19:51:06 PST 
The common case of subtracting one Int/FloatPoint from another is to obtain a relative position or vector, so this should be supported by operator-().  Creating an Int/FloatSize from two Int/FloatPoints is a less common operation and should be made more explicit.

I therefore propose that we ...
- remove 'Int/FloatSize operator-(const int/FloatPoint&, const Int/FloatPoint&)'
- add 'Int/FloatPoint operator-(const int/FloatPoint&, const Int/FloatPoint&)'
- add 'Int/FloatSize Int/FloatSize::fromCornerPoints(const int/FloatPoint&, const Int/FloatPoint&)'
Comment 2 Steve Block 2013-01-08 19:51:19 PST 
Created attachment 181826 [details]
Patch
Comment 3 Steve Block 2013-01-08 19:55:37 PST 
Patch for initial comments. A few things to note ...
- Adding 'FloatPoint::distance(Squared)ToPoint(const FloatPoint&)' can be done in a prerequisite patch - https://bugs.webkit.org/show_bug.cgi?id=105995
- The XCode project file needs updating
- I can move more implementation to the new IntSize.cpp

I'll wait for initial feedback before addressing these things.
Comment 4 Early Warning System Bot 2013-01-08 20:01:32 PST 
Comment on attachment 181826 [details]
Patch

Attachment 181826 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15758372
Comment 5 Early Warning System Bot 2013-01-08 20:04:57 PST 
Comment on attachment 181826 [details]
Patch

Attachment 181826 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15775188
Comment 6 Build Bot 2013-01-08 20:24:13 PST 
Comment on attachment 181826 [details]
Patch

Attachment 181826 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15774198
Comment 7 Build Bot 2013-01-08 20:38:28 PST 
Comment on attachment 181826 [details]
Patch

Attachment 181826 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15766269
Comment 8 EFL EWS Bot 2013-01-08 21:57:14 PST 
Comment on attachment 181826 [details]
Patch

Attachment 181826 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15766309
Comment 9 Steve Block 2013-01-08 22:07:07 PST 
Created attachment 181846 [details]
Patch
Comment 10 Early Warning System Bot 2013-01-08 22:24:33 PST 
Comment on attachment 181846 [details]
Patch

Attachment 181846 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15763395
Comment 11 EFL EWS Bot 2013-01-08 23:00:28 PST 
Comment on attachment 181846 [details]
Patch

Attachment 181846 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15760368
Comment 12 Steve Block 2013-01-08 23:02:23 PST 
Created attachment 181854 [details]
Patch
Comment 13 Build Bot 2013-01-09 00:09:43 PST 
Comment on attachment 181854 [details]
Patch

Attachment 181854 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15764374
Comment 14 Build Bot 2013-01-09 01:08:17 PST 
Comment on attachment 181854 [details]
Patch

Attachment 181854 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15756491
Comment 15 Steve Block 2013-01-09 16:10:17 PST 
Created attachment 182003 [details]
Patch
Comment 16 Build Bot 2013-01-09 17:22:35 PST 
Comment on attachment 182003 [details]
Patch

Attachment 182003 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15759738
Comment 17 Steve Block 2013-01-09 18:14:57 PST 
It seems there ins't the required level of support for this change. See http://lists.webkit.org/pipermail/webkit-dev/2013-January/023212.html