Bug 106408

Summary:

Change semantics of subtracting one Int/FloatPoint from another

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

New Bugs

Assignee:

Steve Block <steveblock>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

aboxhall, andersca, apinheiro, cfleizach, cmarcelo, dino, dmazzoni, d-r, eric, fmalita, gyuyoung.kim, jamesr, jdiggs, junov, macpherson, menard, mifenton, noam, ojan.autocc, pdr, philn, rakuco, schenney, senorblanco, simon.fraser, steveblock, tkent, tonikitoo, webkit-ews, webkit.review.bot, xan.lopez, zeno

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	buildbot: commit-queue-

Steve Block

Reported 2013-01-08 19:37:33 PST

Change semantics of subtracting one Int/FloatPoint from another

Attachments
Patch (58.60 KB, patch) 2013-01-08 19:51 PST, Steve Block	no flags	Details Formatted Diff Diff
Patch (64.94 KB, patch) 2013-01-08 22:07 PST, Steve Block	no flags	Details Formatted Diff Diff
Patch (67.03 KB, patch) 2013-01-08 23:02 PST, Steve Block	no flags	Details Formatted Diff Diff
Patch (68.94 KB, patch) 2013-01-09 16:10 PST, Steve Block	buildbot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Steve Block

Comment 1 2013-01-08 19:51:06 PST

The common case of subtracting one Int/FloatPoint from another is to obtain a relative position or vector, so this should be supported by operator-(). Creating an Int/FloatSize from two Int/FloatPoints is a less common operation and should be made more explicit. I therefore propose that we ... - remove 'Int/FloatSize operator-(const int/FloatPoint&, const Int/FloatPoint&)' - add 'Int/FloatPoint operator-(const int/FloatPoint&, const Int/FloatPoint&)' - add 'Int/FloatSize Int/FloatSize::fromCornerPoints(const int/FloatPoint&, const Int/FloatPoint&)'

Steve Block

Comment 2 2013-01-08 19:51:19 PST

Created attachment 181826 [details] Patch

Steve Block

Comment 3 2013-01-08 19:55:37 PST

Patch for initial comments. A few things to note ... - Adding 'FloatPoint::distance(Squared)ToPoint(const FloatPoint&)' can be done in a prerequisite patch - https://bugs.webkit.org/show_bug.cgi?id=105995 - The XCode project file needs updating - I can move more implementation to the new IntSize.cpp I'll wait for initial feedback before addressing these things.

Early Warning System Bot

Comment 4 2013-01-08 20:01:32 PST

Comment on attachment 181826 [details] Patch Attachment 181826 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15758372

Early Warning System Bot

Comment 5 2013-01-08 20:04:57 PST

Comment on attachment 181826 [details] Patch Attachment 181826 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15775188

Build Bot

Comment 6 2013-01-08 20:24:13 PST

Comment on attachment 181826 [details] Patch Attachment 181826 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15774198

Build Bot

Comment 7 2013-01-08 20:38:28 PST

Comment on attachment 181826 [details] Patch Attachment 181826 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15766269