Summary: | Can't compile MathExtras.h using MinGW-w64 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Liu <net147> | ||||
Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, dglazkov, hausmann, ojan.autocc, sam, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 106099 | ||||||
Attachments: |
|
Description
Jonathan Liu
2013-01-04 10:09:58 PST
Created attachment 181323 [details]
Patch
Attachment 181323 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Ma..." exit_code: 1
Source/WTF/wtf/MathExtras.h:351: wtf_pow is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 181323 [details] Patch Attachment 181323 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15699223 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Comment on attachment 181323 [details] Patch Clearing flags on attachment: 181323 Committed r138894: <http://trac.webkit.org/changeset/138894> All reviewed patches have been landed. Closing bug. |