Bug 106045

Summary: [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, hausmann, kenneth, svillar, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Another patch none

Martin Robinson
Reported 2013-01-03 14:53:10 PST
Selecting a word in an editable region and then clicking causes the word to be deleted.
Attachments
Patch (4.66 KB, patch)
2013-01-03 15:18 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Another patch (2.75 KB, patch)
2013-01-04 09:25 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2013-01-03 15:18:40 PST
Created attachment 181231 [details] Patch
Martin Robinson
Comment 2 2013-01-04 08:34:17 PST
*** Bug 106081 has been marked as a duplicate of this bug. ***
Carlos Garcia Campos
Comment 3 2013-01-04 09:25:09 PST
Created attachment 181315 [details] Another patch I think both patches can be complementary. this patch ensures we do the same than we currently in wk1. GtkInputMethodFilter::notifyMouseButtonPress() calls confirmCurrentComposition() which ends up calling Editor::confirmComposition(), the version without receiving a String. In WebKit2, we are using a single message ConfirmComposition. When confirmCurrentComposition is called in WebKit2 ConfirmComposition message is sent with a NULL String, and the web process ends up calling Editor::confirmComposition(String). We need to handle the special case of the NULL string to call Editor::confirmComposition() without the string.
Carlos Garcia Campos
Comment 4 2013-01-04 09:26:10 PST
Adding Simon and Kenneth to the CC because Qt might be affected by this too.
WebKit Review Bot
Comment 5 2013-01-04 09:29:56 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 6 2013-01-04 09:38:49 PST
Comment on attachment 181231 [details] Patch This looks sane to me, and we save an IPC message when we are not composing. Thanks!
WebKit Review Bot
Comment 7 2013-01-04 09:42:59 PST
Comment on attachment 181231 [details] Patch Clearing flags on attachment: 181231 Committed r138806: <http://trac.webkit.org/changeset/138806>
Sergio Villar Senin
Comment 8 2013-02-08 07:51:56 PST
Should we close this?
Martin Robinson
Comment 9 2013-02-08 07:54:02 PST
The GTK+ parts of this look good to me, but a WebKit2 OWNER needs to look at the other change.
Martin Robinson
Comment 10 2014-03-29 15:15:26 PDT
Are we going to move this one forward?
Carlos Garcia Campos
Comment 11 2014-03-30 03:03:40 PDT
Comment on attachment 181315 [details] Another patch No, this is working fine now
Note You need to log in before you can comment on or make changes to this bug.