Bug 105876

Summary: [EFL] [WebGL] Rename EGLConfigHelper as EGLConfigSelector.
Product: WebKit Reporter: Kalyan <kalyan.kondapally>
Component: WebKit EFLAssignee: Kalyan <kalyan.kondapally>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, kenneth, lucas.de.marchi, noam, rakuco, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 105816    
Attachments:
Description Flags
patch
kenneth: review+, webkit.review.bot: commit-queue-
patchv2
webkit.review.bot: commit-queue-
patch none

Description Kalyan 2012-12-30 14:12:24 PST 
This is to sync the naming conventions of our classes in both EGL and GLX implementations.
In our GLX implementation, class responsible for the same functionality is named as GLXConfigSelector.
Comment 1 Kalyan 2012-12-30 15:18:44 PST 
Created attachment 180961 [details]
patch
Comment 2 WebKit Review Bot 2012-12-30 17:10:39 PST 
Comment on attachment 180961 [details]
patch

Rejecting attachment 180961 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://queues.webkit.org/results/15589687
Comment 3 Kalyan 2012-12-30 21:24:39 PST 
Created attachment 180963 [details]
patchv2
Comment 4 WebKit Review Bot 2012-12-30 21:39:51 PST 
Comment on attachment 180963 [details]
patchv2

Rejecting attachment 180963 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://queues.webkit.org/results/15585773
Comment 5 Chris Dumez 2012-12-30 21:43:15 PST 
Comment on attachment 180963 [details]
patchv2

View in context: https://bugs.webkit.org/attachment.cgi?id=180963&action=review

> Source/WebCore/ChangeLog:1
> +        [EFL] [WebGL] Rename EGLConfigHelper as EGLConfigSelector.

You're missing the first line of this Changelog.
Comment 6 Kalyan 2012-12-30 23:07:47 PST 
Created attachment 180965 [details]
patch
Comment 7 Kalyan 2012-12-30 23:08:52 PST 
(In reply to comment #5)
> (From update of attachment 180963 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180963&action=review
> 
> > Source/WebCore/ChangeLog:1
> > +        [EFL] [WebGL] Rename EGLConfigHelper as EGLConfigSelector.
> 
> You're missing the first line of this Changelog.

thanks. Fixed it now.
Comment 8 WebKit Review Bot 2012-12-30 23:34:17 PST 
Comment on attachment 180965 [details]
patch

Clearing flags on attachment: 180965

Committed r138588: <http://trac.webkit.org/changeset/138588>
Comment 9 WebKit Review Bot 2012-12-30 23:34:23 PST 
All reviewed patches have been landed.  Closing bug.