Bug 105816

Summary:

[EFL][WebGL] Add compile time support for GLES2.

Product:

WebKit

Reporter:

Kalyan <kalyan.kondapally>

Component:

WebKit EFL

Assignee:

Kalyan <kalyan.kondapally>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, tmpsantos, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

105876

Bug Blocks:

105659

Attachments:

Description	Flags
patch	none
patch v2	kenneth: review+, webkit.review.bot: commit-queue-
patchv3	none

Kalyan

Reported 2012-12-27 20:59:00 PST

Add GLES2 compile time support in OptionsEfl.cmake and PlatformEfl.cmake.

Attachments
patch (4.27 KB, patch) 2012-12-27 22:54 PST, Kalyan	no flags	Details Formatted Diff Diff
patch v2 (3.90 KB, patch) 2012-12-31 04:11 PST, Kalyan	kenneth: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
patchv3 (4.00 KB, patch) 2012-12-31 08:35 PST, Kalyan	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Kalyan

Comment 1 2012-12-27 22:54:23 PST

Created attachment 180847 [details] patch

Thiago Marcos P. Santos

Comment 2 2012-12-28 02:15:05 PST

Comment on attachment 180847 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=180847&action=review > Source/cmake/OptionsEfl.cmake:191 > + option(ENABLE_GLES2 ON) > + > + if (ENABLE_GLES2) This if() looks unnecessary since it will never fail. Do we need to set this option()?

Kalyan

Comment 3 2012-12-28 11:52:16 PST

(In reply to comment #2) > (From update of attachment 180847 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180847&action=review > > > Source/cmake/OptionsEfl.cmake:191 > > + option(ENABLE_GLES2 ON) > > + > > + if (ENABLE_GLES2) > > This if() looks unnecessary since it will never fail. Do we need to set this option()? Yes,in order to enable the option (ENABLE_GLES2), we need to pass --cmakeargs="-DENABLE_GLES2=ON" to the built-webkit` script, otherwise it is never set and the if condition will fail. Atleast that's how I understood the usage of option.

Kalyan

Comment 4 2012-12-30 14:14:54 PST

Comment on attachment 180847 [details] patch removing request for cq till https://bugs.webkit.org/show_bug.cgi?id=105876 is done

Kalyan

Comment 5 2012-12-31 04:11:25 PST

Created attachment 180968 [details] patch v2 rebased patch

WebKit Review Bot

Comment 6 2012-12-31 05:00:25 PST

Comment on attachment 180968 [details] patch v2 Rejecting attachment 180968 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15593747

Kenneth Rohde Christiansen

Comment 7 2012-12-31 05:02:31 PST

Comment on attachment 180968 [details] patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=180968&action=review > Source/WebCore/ChangeLog:8 > + [EFL][WebGL] Add compile time support for GLES2. > + https://bugs.webkit.org/show_bug.cgi?id=105816 > + > + This patch adds build support for GLES2. > + GLES2 support can be enabled during compile time by passing -DENABLE_GLES2=ON as > + cmake config parameter. GLES2 options is not enabled by default. This patch doesn't missing reviewer (OOPS!) part

Kalyan

Comment 8 2012-12-31 08:35:33 PST

Created attachment 180977 [details] patchv3

WebKit Review Bot

Comment 9 2012-12-31 08:57:58 PST

Comment on attachment 180977 [details] patchv3 Clearing flags on attachment: 180977 Committed r138598: <http://trac.webkit.org/changeset/138598>

WebKit Review Bot

Comment 10 2012-12-31 08:58:04 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.