Bug 105599

Summary: nrwt: use the same search path for baselines and TestExpectations on apple mac
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, rniwa, simon.fraser, tony, webkit.review.bot
Priority: P2 Keywords: NRWT
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=271331
Attachments:
Description Flags
Patch none

Dirk Pranke
Reported 2012-12-20 18:23:22 PST
nrwt: use the same search path for baselines and TestExpectations on apple mac
Attachments
Patch (4.41 KB, patch)
2012-12-20 18:29 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-12-20 18:29:21 PST
Created attachment 180455 [details] Patch
Dirk Pranke
Comment 2 2012-12-20 18:31:40 PST
See bug 105583 for some context ... it turns out that having the default logic for which expectation files to use match the default logic for the baseline search path is trickier than one might hope, since every port actually does this slightly differently. This is probably bad, so we should clean it up, but I'm going to break this into little patches that affect ports individually where possible, starting w/ the apple mac port.
Ryosuke Niwa
Comment 3 2012-12-20 18:52:59 PST
Do you know if this change affects any effective test expectations on each "leaf" port?
Dirk Pranke
Comment 4 2012-12-20 19:15:22 PST
(In reply to comment #3) > Do you know if this change affects any effective test expectations on each "leaf" port? I do not know. You could determine this by running webkit-patch print-baselines --all --csv --platform mac\* before and after the patch and comparing the output.
Eric Seidel (no email)
Comment 5 2012-12-20 20:16:29 PST
Comment on attachment 180455 [details] Patch I thought most of this logic was implemented in ApplePort these days. :)
Dirk Pranke
Comment 6 2013-01-14 15:28:44 PST
rniwa, smfr, one of you want to weigh in on this?
Dirk Pranke
Comment 7 2013-01-14 15:46:49 PST
thanks!
WebKit Review Bot
Comment 8 2013-01-14 15:52:10 PST
Comment on attachment 180455 [details] Patch Clearing flags on attachment: 180455 Committed r139679: <http://trac.webkit.org/changeset/139679>
WebKit Review Bot
Comment 9 2013-01-14 15:52:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.