| Summary: | nrwt: use the same search path for baselines and TestExpectations on apple mac | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||
| Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, eric, ojan, rniwa, simon.fraser, tony, webkit.review.bot | ||||
| Priority: | P2 | Keywords: | NRWT | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=271331 | ||||||
| Attachments: |
|
||||||
|
Description
Dirk Pranke
2012-12-20 18:23:22 PST
Created attachment 180455 [details]
Patch
See bug 105583 for some context ... it turns out that having the default logic for which expectation files to use match the default logic for the baseline search path is trickier than one might hope, since every port actually does this slightly differently. This is probably bad, so we should clean it up, but I'm going to break this into little patches that affect ports individually where possible, starting w/ the apple mac port. Do you know if this change affects any effective test expectations on each "leaf" port? (In reply to comment #3) > Do you know if this change affects any effective test expectations on each "leaf" port? I do not know. You could determine this by running webkit-patch print-baselines --all --csv --platform mac\* before and after the patch and comparing the output. Comment on attachment 180455 [details]
Patch
I thought most of this logic was implemented in ApplePort these days. :)
rniwa, smfr, one of you want to weigh in on this? thanks! Comment on attachment 180455 [details] Patch Clearing flags on attachment: 180455 Committed r139679: <http://trac.webkit.org/changeset/139679> All reviewed patches have been landed. Closing bug. |