Summary: | REGRESSION(r138215): it broke downstream compilation with clang (Requested by loislo on #webkit). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Review Bot <webkit.review.bot> | ||||
Component: | New Bugs | Assignee: | WebKit Review Bot <webkit.review.bot> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fishd, loislo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 104704 | ||||||
Attachments: |
|
Description
WebKit Review Bot
2012-12-20 01:04:52 PST
Created attachment 180292 [details] ROLLOUT of r138215 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. please fix downstream part first. ../../content/renderer/renderer_webkitplatformsupport_impl.h:71:46: error: 'sharedWorkerRepository' marked 'override' but does not override any member functions virtual WebKit::WebSharedWorkerRepository* sharedWorkerRepository() OVERRIDE; ^ Comment on attachment 180292 [details] ROLLOUT of r138215 Clearing flags on attachment: 180292 Committed r138233: <http://trac.webkit.org/changeset/138233> All reviewed patches have been landed. Closing bug. |