| Summary: | Implement ID selector matching for the WebVTT ::cue pseudo element | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dima Gorbik <dgorbik> | ||||||||
| Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | eric.carlson, feature-media-reviews, koivisto, ojan.autocc, silviapf, webkit-bug-importer, webkit.review.bot | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 105480 | ||||||||||
| Bug Blocks: | 43668, 106762 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dima Gorbik
2012-12-19 16:54:13 PST
Created attachment 180459 [details] Proposed fix 0.1 This patch adds support for cue ID matching and also voice attribute matching for the WebVTT CSS extensions. I will add layout tests after the previous patch is being reviewed (https://bugs.webkit.org/show_bug.cgi?id=105473) because they will be based on the existing layout tests from that patch. Created attachment 182515 [details]
Proposed fix 0.2
Comment on attachment 182515 [details] Proposed fix 0.2 View in context: https://bugs.webkit.org/attachment.cgi?id=182515&action=review > LayoutTests/media/track/track-css-matching.html:54 > consoleWrite(""); > consoleWrite(""); Nit: two blank lines can be added with consoleWrite("<br>"); Created attachment 182675 [details]
Proposed fix 0.2
Comment on attachment 182675 [details] Proposed fix 0.2 Clearing flags on attachment: 182675 Committed r139714: <http://trac.webkit.org/changeset/139714> All reviewed patches have been landed. Closing bug. |