Bug 105481

Summary: Implement ID selector matching for the WebVTT ::cue pseudo element
Product: WebKit Reporter: Dima Gorbik <dgorbik>
Component: MediaAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: eric.carlson, feature-media-reviews, koivisto, ojan.autocc, silviapf, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 105480    
Bug Blocks: 43668, 106762    
Description Flags
Proposed fix 0.1
Proposed fix 0.2
eric.carlson: review+
Proposed fix 0.2 none

Description Dima Gorbik 2012-12-19 16:54:13 PST
More information: http://dev.w3.org/html5/webvtt/#the-'::cue'-pseudo-element
Comment 1 Radar WebKit Bug Importer 2012-12-19 16:55:09 PST
Comment 2 Dima Gorbik 2012-12-20 19:30:10 PST
Created attachment 180459 [details]
Proposed fix 0.1

This patch adds support for cue ID matching and also voice attribute matching for the WebVTT CSS extensions.
I will add layout tests after the previous patch is being reviewed (https://bugs.webkit.org/show_bug.cgi?id=105473) because they will be based on the existing layout tests from that patch.
Comment 3 Dima Gorbik 2013-01-13 23:14:13 PST
Created attachment 182515 [details]
Proposed fix 0.2
Comment 4 Eric Carlson 2013-01-14 08:41:04 PST
Comment on attachment 182515 [details]
Proposed fix 0.2

View in context: https://bugs.webkit.org/attachment.cgi?id=182515&action=review

> LayoutTests/media/track/track-css-matching.html:54
>                  consoleWrite("");
>                  consoleWrite("");

Nit: two blank lines can be added with consoleWrite("<br>");
Comment 5 Dima Gorbik 2013-01-14 18:28:06 PST
Created attachment 182675 [details]
Proposed fix 0.2
Comment 6 WebKit Review Bot 2013-01-14 21:24:09 PST
Comment on attachment 182675 [details]
Proposed fix 0.2

Clearing flags on attachment: 182675

Committed r139714: <http://trac.webkit.org/changeset/139714>
Comment 7 WebKit Review Bot 2013-01-14 21:24:13 PST
All reviewed patches have been landed.  Closing bug.