Bug 104880

Summary: Coordinated Graphics: Small refactor of CoordinatedLayerTreeHost and CoordinatedGraphicsLayer.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: Layout and RenderingAssignee: Dongseong Hwang <dongseong.hwang>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, noam, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103959    
Attachments:
Description Flags
Patch : This patch changes two points.
none
Patch : Delete backing stores explicitly in ~CoordinatedLayerTreeHost(). none

Dongseong Hwang
Reported 2012-12-12 22:27:29 PST
This patch chages two points. 1. Remove layerByIDMap() in CoordinatedGraphicsLayer because it is unused. 2. Remove code swapping m_registeredLayers in CoordinatedLayerTreeHost because setCoordinator(0) does not call detachLayer().
Attachments
Patch : This patch changes two points. (3.79 KB, patch)
2012-12-12 22:47 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch : Delete backing stores explicitly in ~CoordinatedLayerTreeHost(). (4.57 KB, patch)
2012-12-12 23:12 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2012-12-12 22:47:04 PST
Created attachment 179202 [details] Patch : This patch changes two points.
Dongseong Hwang
Comment 2 2012-12-12 23:12:09 PST
Created attachment 179206 [details] Patch : Delete backing stores explicitly in ~CoordinatedLayerTreeHost().
Dongseong Hwang
Comment 3 2012-12-13 16:15:01 PST
ping. It blocks Bug 103959
Dongseong Hwang
Comment 4 2012-12-13 18:40:53 PST
Thanks for review! Could you review the first patch also?
Noam Rosenthal
Comment 5 2012-12-15 10:16:46 PST
Comment on attachment 179202 [details] Patch : This patch changes two points. Please cq+ in your timezone so that you can follow up if it breaks a bot.
Dongseong Hwang
Comment 6 2012-12-15 19:09:58 PST
Thank you for review!
WebKit Review Bot
Comment 7 2012-12-16 18:12:24 PST
Comment on attachment 179206 [details] Patch : Delete backing stores explicitly in ~CoordinatedLayerTreeHost(). Clearing flags on attachment: 179206 Committed r137863: <http://trac.webkit.org/changeset/137863>
WebKit Review Bot
Comment 8 2012-12-16 18:29:08 PST
Comment on attachment 179202 [details] Patch : This patch changes two points. Clearing flags on attachment: 179202 Committed r137866: <http://trac.webkit.org/changeset/137866>
WebKit Review Bot
Comment 9 2012-12-16 18:29:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.