Bug 104796

Summary: Web Inspector: Native Memory Instrumentation: remove fake root MemoryObjectInfo.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, benjamin, keishi, loislo, ojan.autocc, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 104660    
Attachments:
Description Flags
Patch
none
Patch
none
with fixed def file yurys: review+

Ilya Tikhonovsky
Reported 2012-12-12 04:26:20 PST
It was not a good idea to introduce a fake root MemoryObjectInfo. It makes a problem when we visit an object without its own MemoryObjectType. Example: RenderBox has a global pointer to a hash map. HashMap doesn't have its own object type because it is a generic container. It will inherit object type from the fake root memory object info. The same could happen for another container in another class with other MemoryObjectType. This fact forces me to create custom process method for root objects because they need to have their own MemoryObjectInfo with customisable memory object type. patch to follow.
Attachments
Patch (17.23 KB, patch)
2012-12-12 04:30 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (22.67 KB, patch)
2012-12-12 07:24 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
with fixed def file (22.97 KB, patch)
2012-12-12 07:34 PST, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-12-12 04:30:59 PST
Created attachment 179023 [details] Patch
Ilya Tikhonovsky
Comment 2 2012-12-12 07:24:49 PST
Created attachment 179034 [details] Patch
Ilya Tikhonovsky
Comment 3 2012-12-12 07:34:30 PST
Created attachment 179039 [details] with fixed def file
WebKit Review Bot
Comment 4 2012-12-12 07:36:46 PST
Attachment 179039 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/ChangeLog:20: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ilya Tikhonovsky
Comment 5 2012-12-12 08:07:44 PST
Committed r137468: <http://trac.webkit.org/changeset/137468>
Note You need to log in before you can comment on or make changes to this bug.