| Summary: | webdatabase: Split code between the DatabaseManager and DatabaseServer | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||||||||||||||||
| Component: | WebCore Misc. | Assignee: | Mark Lam <mark.lam> | ||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||
| Severity: | Normal | CC: | adamk, ap, beidson, dglazkov, gyuyoung.kim, peter+ews, philn, rakuco, sam, webkit-ews, webkit.review.bot, xan.lopez | ||||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||
| Bug Depends on: | 104741, 104934 | ||||||||||||||||||||||||
| Bug Blocks: | 103668 | ||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||
|
Description
Mark Lam
2012-12-11 17:34:02 PST
Created attachment 179186 [details]
work in progress 1.
Comment on attachment 179186 [details] work in progress 1. Attachment 179186 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15310107 Created attachment 179188 [details]
work in progress again: fixed Qt issue.
Comment on attachment 179188 [details] work in progress again: fixed Qt issue. Attachment 179188 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15322103 Created attachment 179207 [details]
wip1: attempt at fixing the elf build failure.
Created attachment 179429 [details]
work in progress 2: DatabaseTracker is now only accessed from DBBackend::Server + moving more stuff to DatabaseManager and the server.
Comment on attachment 179429 [details] work in progress 2: DatabaseTracker is now only accessed from DBBackend::Server + moving more stuff to DatabaseManager and the server. Attachment 179429 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15311587 Comment on attachment 179429 [details] work in progress 2: DatabaseTracker is now only accessed from DBBackend::Server + moving more stuff to DatabaseManager and the server. Attachment 179429 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15317579 Created attachment 179437 [details]
wip2: + fixed chromium breakage. test ews again.
Comment on attachment 179437 [details] wip2: + fixed chromium breakage. test ews again. Attachment 179437 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15316634 Created attachment 179441 [details]
wip2: + fixed 2nd chromium breakage. test ews again.
Created attachment 179444 [details]
wp2: svn up'ed.
Created attachment 179842 [details]
The final (hopefully) patch.
This patch performs some initial refactoring to split Database functionality between the front-end DatabaseManager and the backend DBBackend::Server. With this patch,
1. All DatabaseTracker accesses now go thru the DBBackend::Server.
2. Database::openDatabase() and DatabaseSync::openDatabaseSync() factory methods have been moved into the DatabaseManager.
3. AbstractDatabase::isAvailable() and AbstractDatabase::setIsAvailable() have been moved into the DatabaseManager.
4. Added DatabaseBasicTypes.h to hold common basic / primitive types that the webdatabase module uses.
This refactoring does not change how the code flows / works yet. It only moves and renames things.
Comment on attachment 179842 [details] The final (hopefully) patch. Attachment 179842 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15374929 Comment on attachment 179842 [details] The final (hopefully) patch. Attachment 179842 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15374928 Created attachment 179855 [details]
The fixed patch: added needed #include's.
Created attachment 179863 [details]
The fixed patch minus some development changes in the Xcode project not ready for a commit yet.
Comment on attachment 179863 [details]
The fixed patch minus some development changes in the Xcode project not ready for a commit yet.
Seeing the pattern that this is largely a refactor that is shuffling code around, I didn't look at certain pieces of it in depth. Seems fine as long as layouttests pass, etc etc.
(In reply to comment #18) > (From update of attachment 179863 [details]) > Seeing the pattern that this is largely a refactor that is shuffling code around, I didn't look at certain pieces of it in depth. Seems fine as long as layouttests pass, etc etc. Yes, this phase of the refactor is largely just shuffling code. The patch has been landed in r138085: <http://trac.webkit.org/changeset/138085>. (In reply to comment #19) > (In reply to comment #18) > > (From update of attachment 179863 [details] [details]) > > Seeing the pattern that this is largely a refactor that is shuffling code around, I didn't look at certain pieces of it in depth. Seems fine as long as layouttests pass, etc etc. > > Yes, this phase of the refactor is largely just shuffling code. > > The patch has been landed in r138085: <http://trac.webkit.org/changeset/138085>. r138085 seems very broken. In particular, at least one file is completely doubled (i.e., contains two copies of the same thing), resulting in compile failures: http://trac.webkit.org/browser/trunk/Source/WebCore/Modules/webdatabase/DBBackendServer.cpp?rev=138085 (In reply to comment #20) > (In reply to comment #19) > > (In reply to comment #18) > > > (From update of attachment 179863 [details] [details] [details]) > > > Seeing the pattern that this is largely a refactor that is shuffling code around, I didn't look at certain pieces of it in depth. Seems fine as long as layouttests pass, etc etc. > > > > Yes, this phase of the refactor is largely just shuffling code. > > > > The patch has been landed in r138085: <http://trac.webkit.org/changeset/138085>. > > r138085 seems very broken. In particular, at least one file is completely doubled (i.e., contains two copies of the same thing), resulting in compile failures: > > http://trac.webkit.org/browser/trunk/Source/WebCore/Modules/webdatabase/DBBackendServer.cpp?rev=138085 My apologies. It looks like a merge issue in my local files. I'm fixing it now. (In reply to comment #21) > My apologies. It looks like a merge issue in my local files. I'm fixing it now. Fixed and landed in r138088: <http://trac.webkit.org/changeset/138088>. |