Bug 104741

Summary:

webdatabase: Encapsulate externally used DB APIs in DatabaseManager

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

WebCore Misc.

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, beidson, dglazkov, gyuyoung.kim, japhet, mifenton, peter+ews, philn, rakuco, rwlbuis, sam, tonikitoo, webkit.review.bot, xan.lopez, yong.li.webkit

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

103668, 104748

Attachments:

Description	Flags
The patch.	webkit.review.bot: commit-queue-
Fixed a few issues, and let's retry with the EWS bots.	none
svn up'ed to get the patch to apply properly.	webkit.review.bot: commit-queue-
Fix bug in chromium port.	eflews.bot: commit-queue-
5th time's the charm: svn up, updated ChangeLog comments.	eflews.bot: commit-queue-
Added a #include to make the elf port happy. Also updated ChangeLog dates and fixed a typo.	none
svn up again to get the patch to apply.	sam: review+

Mark Lam

Reported 2012-12-11 16:41:29 PST

Introduce a DatabaseManager module to encapsulate APIs that are called by code outside the webdatabase module.

Attachments
The patch. (140.86 KB, patch) 2012-12-11 20:53 PST, Mark Lam	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Fixed a few issues, and let's retry with the EWS bots. (147.20 KB, patch) 2012-12-11 23:48 PST, Mark Lam	no flags	Details Formatted Diff Diff
svn up'ed to get the patch to apply properly. (147.12 KB, patch) 2012-12-12 00:02 PST, Mark Lam	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Fix bug in chromium port. (147.12 KB, patch) 2012-12-12 00:24 PST, Mark Lam	eflews.bot: commit-queue-	Details Formatted Diff Diff
5th time's the charm: svn up, updated ChangeLog comments. (148.97 KB, patch) 2012-12-12 07:25 PST, Mark Lam	eflews.bot: commit-queue-	Details Formatted Diff Diff
Added a #include to make the elf port happy. Also updated ChangeLog dates and fixed a typo. (149.35 KB, patch) 2012-12-12 09:47 PST, Mark Lam	no flags	Details Formatted Diff Diff
svn up again to get the patch to apply. (149.16 KB, patch) 2012-12-12 12:48 PST, Mark Lam	sam: review+	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2012-12-11 20:53:53 PST

Created attachment 178956 [details] The patch. Let's see how the EWS bots like it.

WebKit Review Bot

Comment 2 2012-12-11 21:09:13 PST

Comment on attachment 178956 [details] The patch. Attachment 178956 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15277436

Peter Beverloo (cr-android ews)

Comment 3 2012-12-11 21:11:26 PST

Comment on attachment 178956 [details] The patch. Attachment 178956 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15272574

Build Bot

Comment 4 2012-12-11 21:17:15 PST

Comment on attachment 178956 [details] The patch. Attachment 178956 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15284279

EFL EWS Bot

Comment 5 2012-12-11 22:40:52 PST

Comment on attachment 178956 [details] The patch. Attachment 178956 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15281352

Mark Lam

Comment 6 2012-12-11 23:48:00 PST

Created attachment 178981 [details] Fixed a few issues, and let's retry with the EWS bots.

Mark Lam

Comment 7 2012-12-12 00:02:12 PST

Created attachment 178984 [details] svn up'ed to get the patch to apply properly.

WebKit Review Bot

Comment 8 2012-12-12 00:14:43 PST

Comment on attachment 178984 [details] svn up'ed to get the patch to apply properly. Attachment 178984 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15300001

Peter Beverloo (cr-android ews)

Comment 9 2012-12-12 00:23:43 PST

Comment on attachment 178984 [details] svn up'ed to get the patch to apply properly. Attachment 178984 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15276572

Mark Lam

Comment 10 2012-12-12 00:24:13 PST

Created attachment 178988 [details] Fix bug in chromium port.

EFL EWS Bot

Comment 11 2012-12-12 02:14:26 PST

Comment on attachment 178988 [details] Fix bug in chromium port. Attachment 178988 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15272699

Mark Lam

Comment 12 2012-12-12 07:25:02 PST

Created attachment 179035 [details] 5th time's the charm: svn up, updated ChangeLog comments. Let's retry the EWS bots after an svn up to see if the gtk and elf issues are resolved. The failures from the last patch do not seem to be related to the patch.

EFL EWS Bot

Comment 13 2012-12-12 09:23:36 PST

Comment on attachment 179035 [details] 5th time's the charm: svn up, updated ChangeLog comments. Attachment 179035 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15286339

Mark Lam

Comment 14 2012-12-12 09:47:55 PST

Created attachment 179070 [details] Added a #include to make the elf port happy. Also updated ChangeLog dates and fixed a typo.

Mark Lam

Comment 15 2012-12-12 10:24:01 PST

Comment on attachment 179070 [details] Added a #include to make the elf port happy. Also updated ChangeLog dates and fixed a typo. Ready for a review. The elf ews will take a while to process. It was previously complaining about CString only being forward declared. The added #include <wtf/text/CString.h> should take care of the issue.

Mark Lam

Comment 16 2012-12-12 12:48:29 PST

Created attachment 179105 [details] svn up again to get the patch to apply.

Mark Lam

Comment 17 2012-12-12 15:07:32 PST

Landed in r137520: <http://trac.webkit.org/changeset/137520>.

Mark Lam

Comment 18 2012-12-12 16:04:36 PST

aklein reported that r137520 is causing a build breakage in chromium: Undefined symbols: "__ZN7WebCore15DatabaseTracker17initializeTrackerERKN3WTF6StringE", referenced from: __ZN7WebCore15DatabaseManager10initializeERKN3WTF6StringE in libwebcore_remaining.a(DatabaseManager.o) ld: symbol(s) not found The issue is because chromium does not use the same DatabaseTracker class, and hence does not have nor need the call to DatabaseTracker::initializeTracker() function. The fix is landed in r137530: <http://trac.webkit.org/changeset/137530>.

Michael Nordman

Comment 19 2013-01-31 17:08:23 PST

Comment on attachment 178988 [details] Fix bug in chromium port. View in context: https://bugs.webkit.org/attachment.cgi?id=178988&action=review > Source/WebCore/WebCore.gypi:990 > + 'Modules/webdatabase/DatabaseManager.cpp', Please add .h files to webcore.gyi as well when adding new files to webcore. We generally add all files to this gypi, including .cpp files that we actually exclude from our build further downstream (in WebCore.gpy/WebCore.gyp).

Note You need to log in before you can comment on or make changes to this bug.