Bug 104704

Summary: [Chromium] Remove all references to sharedWorkerRepository()
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, haraken, jamesr, tkent+wkapi, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 104838, 105505    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2012-12-11 12:53:50 PST
[Chromium] Remove all references to sharedWorkerRepository()
Attachments
Patch (3.11 KB, patch)
2012-12-11 12:54 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (3.09 KB, patch)
2012-12-19 07:45 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-12-11 12:54:29 PST
Created attachment 178855 [details] Patch
Mark Pilgrim (Google)
Comment 2 2012-12-11 12:54:47 PST
*** Bug 85768 has been marked as a duplicate of this bug. ***
WebKit Review Bot
Comment 3 2012-12-11 12:57:44 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 4 2012-12-12 11:33:13 PST
Comment on attachment 178855 [details] Patch Clearing flags on attachment: 178855 Committed r137490: <http://trac.webkit.org/changeset/137490>
WebKit Review Bot
Comment 5 2012-12-12 11:33:16 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2012-12-12 13:31:18 PST
Re-opened since this is blocked by bug 104838
Mark Pilgrim (Google)
Comment 7 2012-12-19 07:45:27 PST
Created attachment 180163 [details] Patch
Mark Pilgrim (Google)
Comment 8 2012-12-19 07:46:19 PST
Comment on attachment 180163 [details] Patch No longer breaks downstream build because https://codereview.chromium.org/11576028/ has landed.
WebKit Review Bot
Comment 9 2012-12-19 21:24:14 PST
Comment on attachment 180163 [details] Patch Clearing flags on attachment: 180163 Committed r138215: <http://trac.webkit.org/changeset/138215>
WebKit Review Bot
Comment 10 2012-12-19 21:24:18 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 11 2012-12-20 01:04:58 PST
Re-opened since this is blocked by bug 105505
Yury Semikhatsky
Comment 12 2012-12-20 01:06:25 PST
(In reply to comment #9) > (From update of attachment 180163 [details]) > Clearing flags on attachment: 180163 > > Committed r138215: <http://trac.webkit.org/changeset/138215> The change breaks Chromium compilation: ../../content/renderer/renderer_webkitplatformsupport_impl.h:71:46: error: 'sharedWorkerRepository' marked 'override' but does not override any member functions virtual WebKit::WebSharedWorkerRepository* sharedWorkerRepository() OVERRIDE; ^ 1 error generated. You should have removed Chromium override before landing this patch.
Mark Pilgrim (Google)
Comment 13 2013-01-03 13:52:59 PST
Comment on attachment 180163 [details] Patch Should no longer break Chromium compilation now that https://codereview.chromium.org/11744005/ has landed downstream. Patch still applies cleanly to ToT.
WebKit Review Bot
Comment 14 2013-01-03 14:27:20 PST
Comment on attachment 180163 [details] Patch Clearing flags on attachment: 180163 Committed r138742: <http://trac.webkit.org/changeset/138742>
WebKit Review Bot
Comment 15 2013-01-03 14:27:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.