Bug 104676

Summary: [GTK] Force single header includes in GObject DOM bindings
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 104663    
Bug Blocks:    
Attachments:
Description Flags
Patch xan.lopez: review+

Carlos Garcia Campos
Reported 2012-12-11 07:28:15 PST
Only <webkitdom/webkitdom.h> should be allowed from apps.
Attachments
Patch (11.72 KB, patch)
2012-12-11 07:30 PST, Carlos Garcia Campos 		xan.lopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2012-12-11 07:29:49 PST
Won't this break existing code?
Carlos Garcia Campos
Comment 2 2012-12-11 07:30:36 PST
Created attachment 178801 [details] Patch This patch applies on top of patch attached to bug #104663
Carlos Garcia Campos
Comment 3 2012-12-11 07:31:54 PST
Apps are already supposed to only include webkit/webkitdom.h. That's still allowed
Xan Lopez
Comment 4 2013-02-11 11:17:36 PST
(In reply to comment #3) > Apps are already supposed to only include webkit/webkitdom.h. That's still allowed I think this patch is right, but what apps are we talking about exactly? WK1 apps should never include anything other than the single header. I'd assume the same applies for WK2 apps save for the WebProcess plugin stuff?
Xan Lopez
Comment 5 2013-02-11 11:18:17 PST
Comment on attachment 178801 [details] Patch Regardless of the other comments including single DOM headers was never allowed, even if this was missing.
Carlos Garcia Campos
Comment 6 2013-02-18 06:47:06 PST
Committed r143212: <http://trac.webkit.org/changeset/143212>
Note You need to log in before you can comment on or make changes to this bug.