Bug 104663

Summary:

[GTK] Install GObject DOM bindings headers in its own directory

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric.carlson, feature-media-reviews, haraken, japhet, philn, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

104676

Attachments:

Description	Flags
Patch	none
Updated patch to apply on current git master	none
Try to fix the build	none

Carlos Garcia Campos

Reported 2012-12-11 05:33:53 PST

Instead of sharing the webkit1 gtk api directory, move the headers to <webkitdom/webkitdom.h>.

Attachments
Patch (86.56 KB, patch) 2012-12-11 05:40 PST, Carlos Garcia Campos	no flags	Details Formatted Diff Diff
Updated patch to apply on current git master (86.12 KB, patch) 2012-12-11 05:54 PST, Carlos Garcia Campos	no flags	Details Formatted Diff Diff
Try to fix the build (86.21 KB, patch) 2012-12-11 08:49 PST, Carlos Garcia Campos	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2012-12-11 05:40:13 PST

Created attachment 178782 [details] Patch

Carlos Garcia Campos

Comment 2 2012-12-11 05:54:41 PST

Created attachment 178786 [details] Updated patch to apply on current git master

Carlos Garcia Campos

Comment 3 2012-12-11 06:59:12 PST

I think EWS failed because it requires a clean build, I wonder why it didn't generate the bindings again, since the patch modifies the generator script, though.

WebKit Review Bot

Comment 4 2012-12-11 07:02:10 PST

Attachment 178786 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'GNUmakefile.am', u'Source/We..." exit_code: 1 Source/WebKit/gtk/webkit/webkitdom.h:20: #ifndef header guard has wrong style, please use: webkitdom_h [build/header_guard] [5] Total errors found: 1 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.

Carlos Garcia Campos

Comment 5 2012-12-11 08:49:14 PST

Created attachment 178816 [details] Try to fix the build Build break was indeed my fault, I forgot to add new variable for built sources to BUILT_SOURCES. Thanks kov!

WebKit Review Bot

Comment 6 2012-12-11 08:53:25 PST

Attachment 178816 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'GNUmakefile.am', u'Source/We..." exit_code: 1 Source/WebKit/gtk/webkit/webkitdom.h:20: #ifndef header guard has wrong style, please use: webkitdom_h [build/header_guard] [5] Total errors found: 1 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 7 2012-12-11 09:59:04 PST

Comment on attachment 178816 [details] Try to fix the build Clearing flags on attachment: 178816 Committed r137329: <http://trac.webkit.org/changeset/137329>

WebKit Review Bot

Comment 8 2012-12-11 09:59:08 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.