Bug 104660

Summary:

Web Inspector: instrument static parts of RenderBlock and RenderBox

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, benjamin, dglazkov, eric, keishi, loislo, ojan.autocc, peter+ews, pfeldman, philn, pmuellr, vsevik, web-inspector-bugs, webkit-ews, webkit.review.bot, xan.lopez, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

104796

Bug Blocks:

Attachments:

Description	Flags
Patch	none
with fix for Windows	none
will not compile without wkbug 104796	none
rebaseline	yurys: review+

Ilya Tikhonovsky

Reported 2012-12-11 04:41:01 PST

EOM

Attachments
Patch (27.12 KB, patch) 2012-12-11 05:51 PST, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
with fix for Windows (28.58 KB, patch) 2012-12-11 08:42 PST, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
will not compile without wkbug 104796 (8.41 KB, patch) 2012-12-12 04:44 PST, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
rebaseline (8.48 KB, patch) 2012-12-12 08:11 PST, Ilya Tikhonovsky	yurys: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2012-12-11 05:51:01 PST

Created attachment 178785 [details] Patch

Build Bot

Comment 2 2012-12-11 06:15:12 PST

Comment on attachment 178785 [details] Patch Attachment 178785 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15276199

Ilya Tikhonovsky

Comment 3 2012-12-11 08:42:17 PST

Created attachment 178814 [details] with fix for Windows

Yury Semikhatsky

Comment 4 2012-12-12 00:57:45 PST

Comment on attachment 178814 [details] with fix for Windows Let's split this patch into SequenceMemoryInstrumentationTraits changes, addRootObject and actual instrumentation of the static members?

Ilya Tikhonovsky

Comment 5 2012-12-12 04:44:04 PST

Created attachment 179024 [details] will not compile without wkbug 104796

Early Warning System Bot

Comment 6 2012-12-12 04:54:43 PST

Comment on attachment 179024 [details] will not compile without wkbug 104796 Attachment 179024 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15285275

Early Warning System Bot

Comment 7 2012-12-12 04:57:27 PST

Comment on attachment 179024 [details] will not compile without wkbug 104796 Attachment 179024 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15272744

Build Bot

Comment 8 2012-12-12 05:15:50 PST

Comment on attachment 179024 [details] will not compile without wkbug 104796 Attachment 179024 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15285280

WebKit Review Bot

Comment 9 2012-12-12 05:32:16 PST

Comment on attachment 179024 [details] will not compile without wkbug 104796 Attachment 179024 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15275654

EFL EWS Bot

Comment 10 2012-12-12 05:42:30 PST

Comment on attachment 179024 [details] will not compile without wkbug 104796 Attachment 179024 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15276660

Peter Beverloo (cr-android ews)

Comment 11 2012-12-12 06:01:52 PST

Comment on attachment 179024 [details] will not compile without wkbug 104796 Attachment 179024 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15296101

Peter Beverloo (cr-android ews)

Comment 12 2012-12-12 07:03:44 PST

Build Bot

Comment 13 2012-12-12 07:51:36 PST

Comment on attachment 179024 [details] will not compile without wkbug 104796 Attachment 179024 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15281518

Ilya Tikhonovsky

Comment 14 2012-12-12 08:11:13 PST

Created attachment 179048 [details] rebaseline

Yury Semikhatsky

Comment 15 2012-12-12 08:46:50 PST

Comment on attachment 179048 [details] rebaseline View in context: https://bugs.webkit.org/attachment.cgi?id=179048&action=review > Source/WebCore/dom/WebCoreMemoryInstrumentation.h:87 > + static void reportMemoryUsage(WTF::MemoryInstrumentation*); reportStaticMembersMemoryUsage would be more accurate name

Ilya Tikhonovsky

Comment 16 2012-12-12 08:53:50 PST

Committed r137472: <http://trac.webkit.org/changeset/137472>

Note You need to log in before you can comment on or make changes to this bug.