| Summary: | Remove code duplicates from MacroAssemblerARM | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||||
| Component: | JavaScriptCore | Assignee: | Patrick R. Gansterer <paroga> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | barraclough, dbates, fpizlo, loki, oliver, ossy, rgabor, webkit.review.bot, zherczeg | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 108645 | ||||||||
| Attachments: |
|
||||||||
|
Description
Patrick R. Gansterer
2012-12-08 14:22:45 PST
Created attachment 178381 [details]
Patch
Comment on attachment 178381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178381&action=review > Source/JavaScriptCore/assembler/MacroAssemblerARM.h:491 > - m_assembler.ldrUniqueImmediate(ARMRegisters::S0, reinterpret_cast<ARMWord>(address)); > - m_assembler.moveImm(imm.m_value, ARMRegisters::S1); > - m_assembler.dtrUp(ARMAssembler::StoreUint32, ARMRegisters::S1, ARMRegisters::S0, 0); > + move(imm, ARMRegisters::S1); > + store32(ARMRegisters::S1, address); This doesn’t generate the same code. The moveImm will now come first, before the ldrUniqueImmediate. Is that OK? Is one or the other faster? Created attachment 186152 [details]
Patch
Could you check this bug? Comment on attachment 186152 [details] Patch Rejecting attachment 186152 [details] from review queue. oliver@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Comment on attachment 186152 [details] Patch Rejecting attachment 186152 [details] from commit-queue. oliver@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Committed r148134: <http://trac.webkit.org/changeset/148134> |