Bug 104260

Summary: REGRESSION(r136788): Asserts on EFL WebKit2 Debug bot (Requested by yael on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: dongseong.hwang, noam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103843    
Attachments:
Description Flags
ROLLOUT of r136788 none

WebKit Review Bot
Reported 2012-12-06 06:52:06 PST
http://trac.webkit.org/changeset/136788 broke the build: Asserts on EFL WebKit2 Debug bot (Requested by yael on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r136788 (5.69 KB, patch)
2012-12-06 06:52 PST, WebKit Review Bot
no flags
WebKit Review Bot
Comment 1 2012-12-06 06:52:44 PST
Created attachment 178007 [details] ROLLOUT of r136788 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
WebKit Review Bot
Comment 2 2012-12-06 06:57:21 PST
Comment on attachment 178007 [details] ROLLOUT of r136788 Clearing flags on attachment: 178007 Committed r136841: <http://trac.webkit.org/changeset/136841>
WebKit Review Bot
Comment 3 2012-12-06 06:57:24 PST
All reviewed patches have been landed. Closing bug.
Dongseong Hwang
Comment 4 2012-12-07 19:33:03 PST
Comment on attachment 178007 [details] ROLLOUT of r136788 View in context: https://bugs.webkit.org/attachment.cgi?id=178007&action=review > Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:-331 > - ASSERT(m_rootLayerID != InvalidWebLayerID); This bug rolled out wrong bug. The bug that failed debug build is Bug 103983. Bug 103983 renamed from InvalidWebLayerID to CoordinatedLayerID except for this line. However, it's ok. I'll roll back this bug as well as Bug 104260.
Dongseong Hwang
Comment 5 2012-12-07 19:36:42 PST
(In reply to comment #4) > (From update of attachment 178007 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178007&action=review > > > Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:-331 > > - ASSERT(m_rootLayerID != InvalidWebLayerID); > > This bug rolled out wrong bug. > The bug that failed debug build is Bug 103983. > Bug 103983 renamed from InvalidWebLayerID to CoordinatedLayerID except for this line. > However, it's ok. I'll roll back this bug as well as Bug 104260. I think I made a mistake after rethinking. rolling out was good to me. thank you. I'll investigate more.
Note You need to log in before you can comment on or make changes to this bug.