Bug 104106

Summary: Implement add64 for MIPS assembler after r136601
Product: WebKit Reporter: Balazs Kilvady <kilvadyb>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo, fu, galpeter, gergely, ggaren, oliver, ossy, palfia, webkit.review.bot
Priority: P2    
Version: 420+   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 102999    
Attachments:
Description Flags
proposed patch
none
Fixed patch for signed add. none

Balazs Kilvady
Reported 2012-12-05 02:28:25 PST
+++ This bug was initially created as a clone of Bug #104103 +++ r136601 broke the MIPS build: /data/kilvadyb/webkit-mips/webkit/Source/JavaScriptCore/jit/JIT.cpp: In member function 'void JSC::JIT::privateCompileMainPass()': /data/kilvadyb/webkit-mips/webkit/Source/JavaScriptCore/jit/JIT.cpp:241: error: 'add64' was not declared in this scope It seems MIPS assembler needs add64.
Attachments
proposed patch (1.82 KB, patch)
2012-12-05 05:03 PST, Balazs Kilvady 		no flags
DetailsFormatted DiffDiff
Fixed patch for signed add. (2.99 KB, patch)
2012-12-17 08:48 PST, Balazs Kilvady 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Balazs Kilvady
Comment 1 2012-12-05 05:03:04 PST
Created attachment 177730 [details] proposed patch
Peter Gal
Comment 2 2012-12-17 01:56:32 PST
So... are we waiting for something?
Csaba Osztrogonác
Comment 3 2012-12-17 02:06:59 PST
(In reply to comment #2) > So... are we waiting for something? Yes. For review.
Csaba Osztrogonác
Comment 4 2012-12-17 02:13:26 PST
cc more JSC reviewers
Balazs Kilvady
Comment 5 2012-12-17 08:48:57 PST
Created attachment 179753 [details] Fixed patch for signed add.
Zoltan Herczeg
Comment 6 2012-12-17 10:03:34 PST
Comment on attachment 179753 [details] Fixed patch for signed add. r=me. Tricky patch :)
WebKit Review Bot
Comment 7 2012-12-17 10:26:12 PST
Comment on attachment 179753 [details] Fixed patch for signed add. Clearing flags on attachment: 179753 Committed r137919: <http://trac.webkit.org/changeset/137919>
WebKit Review Bot
Comment 8 2012-12-17 10:26:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.