Summary: | [v8] Fix hidden property name of V8ArrayBufferView flag. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ulan Degenbaev <ulan> | ||||||||
Component: | WebGL | Assignee: | Ulan Degenbaev <ulan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, haraken, japhet, kbr, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 68890 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Ulan Degenbaev
2012-12-05 01:22:13 PST
Created attachment 177719 [details]
Patch
Comment on attachment 177719 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177719&action=review Thanks for the patch and sorry for not knowing about V8HiddenPropertyName. Could you please rebase the patch? > Source/WebCore/bindings/v8/V8HiddenPropertyName.h:53 > + V(typedArrayFastSetFlag) Should this be named something like typedArrayHiddenCopyMethod? *** Bug 104192 has been marked as a duplicate of this bug. *** Created attachment 177965 [details]
Patch
Comment on attachment 177965 [details]
Patch
LGTM. Thanks for the fix!
> Should this be named something like typedArrayHiddenCopyMethod? Yes, thanks for catching this. I did the change based on the old patch. > Could you please rebase the patch? Done. This was fast review. Thank you, Kentaro! Comment on attachment 177965 [details] Patch Rejecting attachment 177965 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ing file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/bindings/v8/V8HiddenPropertyName.h Hunk #1 FAILED at 49. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/v8/V8HiddenPropertyName.h.rej patching file Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15159623 Looks like you need to rebase it once again. Created attachment 177967 [details]
Patch
Comment on attachment 177967 [details] Patch Clearing flags on attachment: 177967 Committed r136824: <http://trac.webkit.org/changeset/136824> All reviewed patches have been landed. Closing bug. |