Bug 103918 – [CMake] Enable building WebKit sources without Tools

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Laszlo Gombos]

This build configuration could be useful for:
 - downstream in a productization branch for package maintainers) where Tools directory might not be used/needed
 - building just WebKit sources without building Tools for faster build times
 - ENABLE_TOOLS cmake variable was always set to true, which made not much sense - we should allow it to be configurable

[Laszlo Gombos]

Created attachment 177313 [details]
proposed patch

Also moved a section of the code so that the TOOLS_DIR variable is initialized before it gets used.

As a test I create a directory with only CMakeLists.txt file and the Source directory in it and successfully built the EFL WebKit port from it by invoking cmake directly (instead of using the build-webkit script).

[Gyuyoung Kim]

Comment on attachment 177313 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177313&action=review

Looks find on my side.

> CMakeLists.txt:-14
> -SET(ENABLE_WEBCORE ON)

Should we move existing place to here ?

[Gyuyoung Kim]

Comment on attachment 177313 [details]
proposed patch

typo : find -> fine.

[Laszlo Gombos]

(In reply to comment #2)
> (From update of attachment 177313 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177313&action=review
> 
> Looks find on my side.
> 
> > CMakeLists.txt:-14
> > -SET(ENABLE_WEBCORE ON)
> 
> Should we move existing place to here ?

This should be done together with a bigger refactoring as a separate patch. I think this variable should not even be exposed at this level and should be moved under Source - see bug 104083.

[WebKit Review Bot]

Comment on attachment 177313 [details]
proposed patch

Clearing flags on attachment: 177313

Committed r136715: <http://trac.webkit.org/changeset/136715>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.