Bug 103734

Summary: [EFL] Gardening after r136031 and r136142
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit EFLAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, jussi.kukkonen, lucas.de.marchi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sudarsana Nagineni (babu)
Reported 2012-11-30 04:49:08 PST
http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug%20WK2/builds/6522 - API test EWK2UnitTestBase.ewk_view_setting_encoding_custom is asserting after r136031 - Newly added test fast/ruby/position-after.html is missing expected results. - The following tests are expected to fail, but passed compositing/regions/webkit-flow-renderer-layer-compositing.html fast/backgrounds/background-opaque-images-over-color.html media/controls-right-click-on-timebar.html compositing/reflections/load-video-in-reflection.html
Attachments
Patch (deleted)
2012-11-30 05:01 PST, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (14.94 KB, patch)
2012-11-30 05:18 PST, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2012-11-30 05:01:36 PST
Created attachment 176944 [details] Patch
Dominik Röttsches (drott)
Comment 2 2012-11-30 05:16:01 PST
Pending an update of the patch.
Sudarsana Nagineni (babu)
Comment 3 2012-11-30 05:18:21 PST
Created attachment 176946 [details] Patch
Jussi Kukkonen (jku)
Comment 4 2012-11-30 05:20:15 PST
The ruby test mac result is actually correct for txt for us too so could be moved to non-platform specific dir, but I guess that's not a big deal. I was about to do that yesterday but I did not understand the image result difference so I didn't https://bugs.webkit.org/show_bug.cgi?id=103569
WebKit Review Bot
Comment 5 2012-11-30 05:45:49 PST
Comment on attachment 176946 [details] Patch Clearing flags on attachment: 176946 Committed r136230: <http://trac.webkit.org/changeset/136230>
WebKit Review Bot
Comment 6 2012-11-30 05:45:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.