Bug 103734 - [EFL] Gardening after r136031 and r136142
Summary: [EFL] Gardening after r136031 and r136142
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sudarsana Nagineni (babu)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-30 04:49 PST by Sudarsana Nagineni (babu)
Modified: 2012-11-30 05:45 PST (History)
4 users (show)

See Also:

Attachments
Patch (deleted)
2012-11-30 05:01 PST, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
Patch (14.94 KB, patch)
2012-11-30 05:18 PST, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2012-11-30 04:49:08 PST 
http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug%20WK2/builds/6522

- API test EWK2UnitTestBase.ewk_view_setting_encoding_custom is asserting after r136031
- Newly added test fast/ruby/position-after.html is missing expected results.
- The following tests are expected to fail, but passed
  compositing/regions/webkit-flow-renderer-layer-compositing.html
  fast/backgrounds/background-opaque-images-over-color.html
  media/controls-right-click-on-timebar.html
  compositing/reflections/load-video-in-reflection.html
Comment 1 Sudarsana Nagineni (babu) 2012-11-30 05:01:36 PST 
Created attachment 176944 [details]
Patch
Comment 2 Dominik Röttsches (drott) 2012-11-30 05:16:01 PST 
Pending an update of the patch.
Comment 3 Sudarsana Nagineni (babu) 2012-11-30 05:18:21 PST 
Created attachment 176946 [details]
Patch
Comment 4 Jussi Kukkonen (jku) 2012-11-30 05:20:15 PST 
The ruby test mac result is actually correct for txt for us too so could be moved to non-platform specific dir, but I guess that's not a big deal.

I was about to do that yesterday but I did not understand the image result difference so I didn't https://bugs.webkit.org/show_bug.cgi?id=103569
Comment 5 WebKit Review Bot 2012-11-30 05:45:49 PST 
Comment on attachment 176946 [details]
Patch

Clearing flags on attachment: 176946

Committed r136230: <http://trac.webkit.org/changeset/136230>
Comment 6 WebKit Review Bot 2012-11-30 05:45:53 PST 
All reviewed patches have been landed.  Closing bug.