Bug 103648 – [chromium] Tell WebInputHandlerClient when end of input is reached for current vsync period

• Component: New Bugs
• Status: RESOLVED FIXED

[Sami Kyöstilä]

[chromium] Tell WebInputHandlerClient when end of input is reached for current vsync period

[Sami Kyöstilä]

Created attachment 176778 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Peter Beverloo (cr-android ews)]

Comment on attachment 176778 [details]
Patch

Attachment 176778 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15056037

[Darin Fisher (:fishd, Google)]

Comment on attachment 176778 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176778&action=review

> Source/Platform/chromium/public/WebInputHandlerClient.h:78
> +    virtual void onEndOfInput() { }

nit: WebKit APIs do not normally use the "on" prefix for events.  Prefer "did" or "will" as suffixes to make it more clear if the event is occurring before or after some state change.

[WebKit Review Bot]

Comment on attachment 176778 [details]
Patch

Attachment 176778 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15054138

[Sami Kyöstilä]

(In reply to comment #4)
> nit: WebKit APIs do not normally use the "on" prefix for events.  Prefer "did" or "will" as suffixes to make it more clear if the event is occurring before or after some state change.

Great point, done.

[Sami Kyöstilä]

Created attachment 177268 [details]
Patch

[Peter Beverloo]

Comment on attachment 177268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177268&action=review

Some minor drive-by nits..

> Source/Platform/chromium/public/WebInputHandlerClient.h:76
> +    // Indicate that the final input evet for the current vsync interval was

nit: s/evet/event/.  Since there is no 80-character line length limit in WebKit, it should be fine to put "received." on this line.

[Sami Kyöstilä]

(In reply to comment #8)
> nit: s/evet/event/.  Since there is no 80-character line length limit in WebKit, it should be fine to put "received." on this line.

Thanks, fixed.

[Sami Kyöstilä]

Created attachment 177274 [details]
Patch

[WebKit Review Bot]

Comment on attachment 177274 [details]
Patch

Clearing flags on attachment: 177274

Committed r136421: <http://trac.webkit.org/changeset/136421>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.