Bug 103461

Summary: Remove ASSERT_NOT_REACHED() from IDBCursorBackendImpl::postSuccessHandlerCallback()
Product: WebKit Reporter: Michael Pruett <michael>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, haraken, jsbell, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 45110    
Attachments:
Description Flags
Patch none

Michael Pruett
Reported 2012-11-27 16:01:43 PST
In the Chromium port, IDBCursorBackendImpl::postSuccessHandlerCallback() is never invoked, but the ASSERT_NOT_REACHED() macro should be removed in order to allow IndexedDB to be implemented for JSC.
Attachments
Patch (1.88 KB, patch)
2012-11-27 16:09 PST, Michael Pruett 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Pruett
Comment 1 2012-11-27 16:09:17 PST
Created attachment 176356 [details] Patch
Alec Flett
Comment 2 2012-11-27 16:29:13 PST
Comment on attachment 176356 [details] Patch if that's there, it almost always means that function is in the process of being removed. Why do you need it?
Joshua Bell
Comment 3 2012-11-27 16:34:28 PST
(In reply to comment #2) > if that's there, it almost always means that function is in the process of being removed. Why do you need it? I think it's part of the pre-fetching logic, but let me dig in. It's possible it's not even needed any more.
Joshua Bell
Comment 4 2012-11-27 16:41:17 PST
Yeah, Chromium code uses this to reset the prefetch cache if the success handler did anything other than continue(). It's safe to remove this ASSERT.
Kentaro Hara
Comment 5 2012-11-27 20:41:42 PST
Comment on attachment 176356 [details] Patch rs=me, per the discussion in the bug.
WebKit Review Bot
Comment 6 2012-11-27 20:54:50 PST
Comment on attachment 176356 [details] Patch Clearing flags on attachment: 176356 Committed r135969: <http://trac.webkit.org/changeset/135969>
WebKit Review Bot
Comment 7 2012-11-27 20:54:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.