Summary: | [V8] Replace toWebCoreString()/toWebCoreAtomicString() with V8Parameter | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||
Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Normal | CC: | abarth | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 103340, 103341, 103367, 103391, 103397, 103404 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Kentaro Hara
2012-11-26 17:23:14 PST
Created attachment 176130 [details]
micro benchmarks
Hmm, it looks like 10% slowness was placebo. The perf is a bit flaky.
As far as I test with the micro benchmarks attached to this bug and Bindings/id-setter.html a lot of times, there is no observable perf diff between V8Parameter and toWebCoreString()/toWebCoreAtomicString().
So the conclusion is that V8Parameter is as fast as toWebCoreString()/toWebCoreAtomicString(), and thus we can replace toWebCoreString()/toWebCoreAtomicString() with V8Parameter without regressing performance.
Closing some V8-related work items. |