Bug 103391 - [V8] Replace toWebCoreString()/toWebCoreAtomicString() in CodeGeneratorV8.pm with V8StringResource
Summary: [V8] Replace toWebCoreString()/toWebCoreAtomicString() in CodeGeneratorV8.pm ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 103331
  Show dependency treegraph
Reported: 2012-11-27 04:23 PST by Kentaro Hara
Modified: 2012-11-27 16:19 PST (History)
3 users (show)

See Also:

Patch (7.22 KB, patch)
2012-11-27 04:25 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-11-27 04:23:18 PST
This is an incremental effort for fixing bug 103331.
Comment 1 Kentaro Hara 2012-11-27 04:25:15 PST
Created attachment 176230 [details]
Comment 2 WebKit Review Bot 2012-11-27 14:30:34 PST
Comment on attachment 176230 [details]

Clearing flags on attachment: 176230

Committed r135922: <http://trac.webkit.org/changeset/135922>
Comment 3 WebKit Review Bot 2012-11-27 14:30:38 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Kentaro Hara 2012-11-27 16:19:37 PST
By this change, all value conversions in generated code are already surrounded by TRYCATCH() blocks correctly. On the other hand, a huge amount of value conversions in custom bindings are missing TRYCATCH() blocks, which we want to fix at some point.