WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
103397
[V8] Remove toWebCoreAtomicString() from bindings/v8/*
https://bugs.webkit.org/show_bug.cgi?id=103397
Summary
[V8] Remove toWebCoreAtomicString() from bindings/v8/*
Kentaro Hara
Reported
2012-11-27 04:38:08 PST
This is an incremental effort for fixing
bug 103331
.
Attachments
Patch
(13.48 KB, patch)
2012-11-27 04:59 PST
,
Kentaro Hara
haraken
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kentaro Hara
Comment 1
2012-11-27 04:59:47 PST
Created
attachment 176238
[details]
Patch
Adam Barth
Comment 2
2012-11-27 09:28:48 PST
Comment on
attachment 176238
[details]
Patch In these cases, it looks like the types are roughly v8::Handle<v8::String>, which means the try/catch block isn't needed. Perhaps we should have a more optimized code path when we know that IsString() is true?
Kentaro Hara
Comment 3
2012-11-27 15:55:52 PST
Comment on
attachment 176238
[details]
Patch For now let me pause this work because it would require a bunch of efforts to complete it (
https://bugs.webkit.org/show_bug.cgi?id=103404#c4
)
Anders Carlsson
Comment 4
2013-05-02 11:49:51 PDT
V8 is gone from WebKit.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug