Bug 103033

Summary: INPUT_MULTIPLE_FIELDS_UI: Refactoring: Do not call updateInnerTextValue if only read-only sub-fields have values
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, mifenton, morrita, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 102645    
Bug Blocks: 102861    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Kent Tamura
Reported 2012-11-22 00:40:03 PST
INPUT_MULTIPLE_FIELDS_UI: Refactoring: Do not call updateInnerTextValue if only read-only sub-fields have values
Attachments
Patch (8.15 KB, patch)
2012-11-22 00:57 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.16 KB, patch)
2012-11-22 01:08 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.15 KB, patch)
2012-11-22 01:11 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-11-22 00:57:44 PST
Created attachment 175615 [details] Patch
Kentaro Hara
Comment 2 2012-11-22 01:03:25 PST
Comment on attachment 175615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175615&action=review > LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html:23 > +shouldNotBe('eventSender.keyDown("upArrow"); getUserAgentShadowTextContent(input)', 'initialText'); Instead of shouldNotBe(), how about dumping the value of getUserAgentShadowTextContent(input) ? Given that you're dumping initialText, the test result is already platform-dependent.
Kent Tamura
Comment 3 2012-11-22 01:08:27 PST
Created attachment 175616 [details] Patch for landing
Kent Tamura
Comment 4 2012-11-22 01:10:31 PST
Comment on attachment 175615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175615&action=review >> LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html:23 >> +shouldNotBe('eventSender.keyDown("upArrow"); getUserAgentShadowTextContent(input)', 'initialText'); > > Instead of shouldNotBe(), how about dumping the value of getUserAgentShadowTextContent(input) ? Given that you're dumping initialText, the test result is already platform-dependent. Yeah, it's better for test result readability. The time formats in en-US locale on ICU/Windows/Mac are identical. We don't need to worry about platform dependency here.
Kent Tamura
Comment 5 2012-11-22 01:11:30 PST
Created attachment 175618 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-11-22 05:46:41 PST
Comment on attachment 175618 [details] Patch for landing Clearing flags on attachment: 175618 Committed r135510: <http://trac.webkit.org/changeset/135510>
WebKit Review Bot
Comment 7 2012-11-22 05:46:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.