| Summary: | [Shadow DOM] Kill ShadowRoot constructor | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hajime Morrita <morrita> | ||||||||||||
| Component: | DOM | Assignee: | Hayato Ito <hayato> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | abarth, dglazkov, ericbidelman, eric.carlson, feature-media-reviews, gyuyoung.kim, hayato, ojan.autocc, rakuco, syoichi, webcomponents-bugzilla, webkit.review.bot | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 102911, 104238, 104770 | ||||||||||||||
| Bug Blocks: | 63606 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Hajime Morrita
2012-11-21 02:51:27 PST
Created attachment 178510 [details]
wip. need to update exported symbols.
Created attachment 178518 [details]
Update DOMWindow.idl
Comment on attachment 178518 [details] Update DOMWindow.idl Attachment 178518 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15236485 New failing tests: fast/frames/detached-shadow-frame.html inspector/elements/shadow-root.html Comment on attachment 178518 [details] Update DOMWindow.idl Attachment 178518 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15257304 New failing tests: editing/shadow/breaking-editing-boundaries-2.html fast/dom/shadow/insertion-point-resetStyleInheritance.html editing/shadow/selection-of-shadowroot.html inspector/elements/shadow-root.html inspector/elements/update-shadowdom.html editing/shadow/execcommand-indent-in-shadow.html editing/shadow/insertorderedlist-crash.html editing/shadow/delete-list-in-shadow.html editing/shadow/contenteditable-propagation-at-shadow-boundary.html editing/shadow/rightclick-on-meter-in-shadow-crash.html editing/shadow/selection-of-orphan-shadowroot.html editing/shadow/doubleclick-on-meter-in-shadow-crash.html editing/shadow/shadow-selection-not-exported.html editing/shadow/select-contenteditable-shadowhost.html editing/shadow/pressing-enter-on-list.html editing/shadow/adjusting-editing-boundary-with-table-in-shadow.html editing/shadow/breaking-editing-boundaries.html editing/shadow/delete-characters-in-distributed-node-crash.html editing/shadow/compare-positions-in-nested-shadow.html editing/shadow/breaking-editing-boundary-with-table.html editing/shadow/bold-twice-in-shadow.html Created attachment 178694 [details]
further updating.
Created attachment 178715 [details]
fix a test on mac.
Comment on attachment 178715 [details] fix a test on mac. Clearing flags on attachment: 178715 Committed r137408: <http://trac.webkit.org/changeset/137408> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 104770 Created attachment 179163 [details]
relanding.
Let me re-land the patch after https://codereview.chromium.org/11548020/ is resolved. Since I've not reverted the layout tests, this re-landing patch just deletes the constructor. (In reply to comment #10) > Created an attachment (id=179163) [details] > relanding. Comment on attachment 179163 [details] relanding. Clearing flags on attachment: 179163 Committed r137870: <http://trac.webkit.org/changeset/137870> All reviewed patches have been landed. Closing bug. |