Bug 102806

Summary: [V8] Introduce GenerateConstructorHeader() to CodeGeneratorV8.pm
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 102763    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-11-20 05:47:19 PST
This is an incremental step for introducing constructorCallbackCustom(). See bug 102763.
Attachments
Patch (4.36 KB, patch)
2012-11-20 05:49 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-11-20 05:49:10 PST
Created attachment 175197 [details] Patch
Adam Barth
Comment 2 2012-11-20 10:53:26 PST
Comment on attachment 175197 [details] Patch ok
WebKit Review Bot
Comment 3 2012-11-20 15:42:57 PST
Comment on attachment 175197 [details] Patch Clearing flags on attachment: 175197 Committed r135322: <http://trac.webkit.org/changeset/135322>
WebKit Review Bot
Comment 4 2012-11-20 15:43:00 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 5 2012-11-20 22:02:56 PST
(In reply to comment #3) > (From update of attachment 175197 [details]) > Clearing flags on attachment: 175197 > > Committed r135322: <http://trac.webkit.org/changeset/135322> It broke the bindings tests on the bots. Could you fix it?
Kentaro Hara
Comment 6 2012-11-20 22:04:35 PST
(In reply to comment #5) > (In reply to comment #3) > > (From update of attachment 175197 [details] [details]) > > Clearing flags on attachment: 175197 > > > > Committed r135322: <http://trac.webkit.org/changeset/135322> > > It broke the bindings tests on the bots. Could you fix it? I think it I already fixed it. But it looks like another patch broke the test again. I'll fix it in mins.
Kentaro Hara
Comment 7 2012-11-20 22:08:10 PST
(In reply to comment #6) > > It broke the bindings tests on the bots. Could you fix it? > > I think it I already fixed it. But it looks like another patch broke the test again. I'll fix it in mins. Fixed in r135351.
Note You need to log in before you can comment on or make changes to this bug.