Summary: | [V8] Introduce constructorCallbackCustom() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 102770, 102806 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Kentaro Hara
2012-11-19 20:52:54 PST
Sounds good to me. Created attachment 175301 [details]
Patch
Comment on attachment 175301 [details]
Patch
Very nice.
Created attachment 175306 [details]
patch for landing
Comment on attachment 175306 [details] patch for landing Rejecting attachment 175306 [details] from commit-queue. New failing tests: fast/dom/call-a-constructor-as-a-function.html Full output: http://queues.webkit.org/results/14933559 Committed r135346: <http://trac.webkit.org/changeset/135346> (In reply to comment #5) > New failing tests: > fast/dom/call-a-constructor-as-a-function.html > Full output: http://queues.webkit.org/results/14933559 Updated the test result and landed the patch. It looks like that '.' was missing in an error message of DataView's custom constructors:) Now we have '.' for all custom constructors because the same error message is generated by the code generator. |