Summary: | Simulated mouse events should return an accurate offset. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Lee <jonlee> | ||||
Component: | UI Events | Assignee: | Jon Lee <jonlee> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, ap, beidson, mitz, sam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.8 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 98318 | ||||||
Attachments: |
|
Description
Jon Lee
2012-11-17 22:24:20 PST
Created attachment 174843 [details]
Patch
Comment on attachment 174843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174843&action=review > Source/WebCore/ChangeLog:10 > + Remove an old check to avoid adjusting the offset location, because we now recalculate the > + offset from scratch and cache it. It took me awhile to realize what you meant here. I thought you were implying that this change also made us cache the offset. Maybe clarify something like: "Originally we did the isSimulated check. Then sometime later, we started caching the offset. I realized that caching the offset made the isSimulated check irrelevant, so lets remove it" (In reply to comment #3) > (From update of attachment 174843 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174843&action=review > > > Source/WebCore/ChangeLog:10 > > + Remove an old check to avoid adjusting the offset location, because we now recalculate the > > + offset from scratch and cache it. > > It took me awhile to realize what you meant here. I thought you were implying that this change also made us cache the offset. > > Maybe clarify something like: > "Originally we did the isSimulated check. Then sometime later, we started caching the offset. I realized that caching the offset made the isSimulated check irrelevant, so lets remove it" Yes, this needs better explanation. i will clarify in the submitted changelog. Committed r135065: <http://trac.webkit.org/changeset/135065> |