Bug 102430

Summary:

IndexedDB: Propagate DOMRequestState to IndexedDB binding utility functions

Product:

WebKit

Reporter:

Michael Pruett <michael>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, alecflett, haraken, japhet, jsbell, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

45110

Attachments:

Description	Flags
Propagate DOMRequestState to IndexedDB binding utility functions	abarth: review+
Propagate DOMRequestState to IndexedDB binding utility functions	none

Michael Pruett

Reported 2012-11-15 14:11:44 PST

Currently the DOMRequestState maintained in IDBRequest is propagated to deserializeIDBValue() and idbKeyToScriptValue(). This approach is fine for the V8 implementation of the IDB binding utilities, but in order to implement the binding utilities for JSC, the DOMRequestState should be propagated to injectIDBKeyIntoScriptValue(), createIDBKeyFromScriptValueAndKeyPath(), and canInjectIDBKeyIntoScriptValue() as well.

Attachments
Propagate DOMRequestState to IndexedDB binding utility functions (15.88 KB, patch) 2012-11-15 14:52 PST, Michael Pruett	abarth: review+	Details Formatted Diff Diff
Propagate DOMRequestState to IndexedDB binding utility functions (15.87 KB, patch) 2012-11-16 10:28 PST, Michael Pruett	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Michael Pruett

Comment 1 2012-11-15 14:52:46 PST

Created attachment 174525 [details] Propagate DOMRequestState to IndexedDB binding utility functions

Alec Flett

Comment 2 2012-11-15 17:07:55 PST

Comment on attachment 174525 [details] Propagate DOMRequestState to IndexedDB binding utility functions In general this LGTM, I wonder if we'll also have to stick in some Scope()'s as well. But for now, lets leave them out optimistically.

Adam Barth

Comment 3 2012-11-15 17:50:07 PST

Comment on attachment 174525 [details] Propagate DOMRequestState to IndexedDB binding utility functions What is a DOMRequestState in JSC? http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/js/DOMRequestState.h didn't find anything.

Michael Pruett

Comment 4 2012-11-15 18:01:32 PST

(In reply to comment #3) > (From update of attachment 174525 [details]) > What is a DOMRequestState in JSC? http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/js/DOMRequestState.h didn't find anything. I haven't yet submitted a patch adding the JSC implementation of DOMRequestState, but I envision it being fairly similar to the IDBJSContext class in Source/WebCore/bindings/js/IDBBindingUtilities.cpp in the most recent patch I submitted for <https://bugs.webkit.org/show_bug.cgi?id=45110>.

Adam Barth

Comment 5 2012-11-16 09:19:40 PST

Comment on attachment 174525 [details] Propagate DOMRequestState to IndexedDB binding utility functions Ok, so it's basically the exec state. Then this patch makes sense.

Michael Pruett

Comment 6 2012-11-16 10:28:34 PST

Created attachment 174719 [details] Propagate DOMRequestState to IndexedDB binding utility functions I've updated ChangeLogs adding Adam Barth as the reviewer.

Joshua Bell

Comment 7 2012-11-16 10:35:20 PST

Comment on attachment 174719 [details] Propagate DOMRequestState to IndexedDB binding utility functions FYI, the commit queue will automaticaly update the CLs with the reviewer if a committer checks cq+.

WebKit Review Bot

Comment 8 2012-11-16 12:57:07 PST

Comment on attachment 174719 [details] Propagate DOMRequestState to IndexedDB binding utility functions Clearing flags on attachment: 174719 Committed r134989: <http://trac.webkit.org/changeset/134989>

WebKit Review Bot

Comment 9 2012-11-16 12:57:11 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.