Bug 102400

Summary:

Update DOMException name: InvalidAccessError

Product:

WebKit

Reporter:

Erik Arvidsson <arv>

Component:

New Bugs

Assignee:

Erik Arvidsson <arv>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

haraken, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

101606

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Erik Arvidsson 2012-11-15 09:14:12 PST

Update DOMException name: InvalidAccessError

Comment 1 Erik Arvidsson 2012-11-15 09:15:09 PST

Created attachment 174461 [details]
Patch

Comment 2 Kentaro Hara 2012-11-15 16:15:32 PST

Comment on attachment 174461 [details]
Patch

You might want to add a "Histrical" comment on ExceptionCode.h. (Instead of adding the "Historical" comment on each line, you can add the comment at the top of ExceptionCode enums.)

Comment 3 Erik Arvidsson 2012-11-16 06:13:37 PST

(In reply to comment #2)
> (From update of attachment 174461 [details])
> You might want to add a "Histrical" comment on ExceptionCode.h. (Instead of adding the "Historical" comment on each line, you can add the comment at the top of ExceptionCode enums.)

There is a comment above the enum explaining what is going regarding the historical error types.

Comment 4 Erik Arvidsson 2012-11-16 06:48:19 PST

Created attachment 174674 [details]
Patch for landing

Comment 5 WebKit Review Bot 2012-11-16 07:44:48 PST

Comment on attachment 174674 [details]
Patch for landing

Clearing flags on attachment: 174674

Committed r134949: <http://trac.webkit.org/changeset/134949>

Comment 6 WebKit Review Bot 2012-11-16 07:44:52 PST

All reviewed patches have been landed.  Closing bug.