Bug 102400

Summary: Update DOMException name: InvalidAccessError
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: New BugsAssignee: Erik Arvidsson <arv>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101606    
Attachments:
Description Flags
Patch
none
Patch for landing none

Erik Arvidsson
Reported 2012-11-15 09:14:12 PST
Update DOMException name: InvalidAccessError
Attachments
Patch (48.11 KB, patch)
2012-11-15 09:15 PST, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Patch for landing (48.10 KB, patch)
2012-11-16 06:48 PST, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Erik Arvidsson
Comment 1 2012-11-15 09:15:09 PST
Created attachment 174461 [details] Patch
Kentaro Hara
Comment 2 2012-11-15 16:15:32 PST
Comment on attachment 174461 [details] Patch You might want to add a "Histrical" comment on ExceptionCode.h. (Instead of adding the "Historical" comment on each line, you can add the comment at the top of ExceptionCode enums.)
Erik Arvidsson
Comment 3 2012-11-16 06:13:37 PST
(In reply to comment #2) > (From update of attachment 174461 [details]) > You might want to add a "Histrical" comment on ExceptionCode.h. (Instead of adding the "Historical" comment on each line, you can add the comment at the top of ExceptionCode enums.) There is a comment above the enum explaining what is going regarding the historical error types.
Erik Arvidsson
Comment 4 2012-11-16 06:48:19 PST
Created attachment 174674 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-11-16 07:44:48 PST
Comment on attachment 174674 [details] Patch for landing Clearing flags on attachment: 174674 Committed r134949: <http://trac.webkit.org/changeset/134949>
WebKit Review Bot
Comment 6 2012-11-16 07:44:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.