Bug 102153

Summary: [chromium] Remove the WebCompositorSupport virtual methods from the base class
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: backer, dglazkov, jamesr, peter+ews, piman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 101968, 102700    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing none

Dana Jansens
Reported 2012-11-13 16:38:13 PST
[chromium] Remove the WebCompositorSupport virtual methods from the base class
Attachments
Patch (1.92 KB, patch)
2012-11-13 16:38 PST, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.63 KB, patch)
2012-11-19 11:03 PST, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-11-13 16:38:52 PST
Created attachment 174025 [details] Patch
Dana Jansens
Comment 2 2012-11-13 16:39:39 PST
This also depends on https://codereview.chromium.org/11410075
WebKit Review Bot
Comment 3 2012-11-13 22:10:14 PST
Comment on attachment 174025 [details] Patch Attachment 174025 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14831207
Peter Beverloo (cr-android ews)
Comment 4 2012-11-13 22:55:47 PST
Comment on attachment 174025 [details] Patch Attachment 174025 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14826483
Dana Jansens
Comment 5 2012-11-17 08:50:14 PST
Once chromium rolls into WebKit, this'll be ready to land. Can I get a review please?
WebKit Review Bot
Comment 6 2012-11-19 09:19:30 PST
Comment on attachment 174025 [details] Patch Rejecting attachment 174025 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /chromium/tests/LinkHighlightTest.o Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp: In constructor '<unnamed>::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest()': Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp:63: error: 'class WebKit::WebCompositorSupport' has no member named 'setAcceleratedAnimationEnabled' make: *** [out/Release/obj.target/webkit_unit_tests/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/14899255
Dana Jansens
Comment 7 2012-11-19 11:03:04 PST
Created attachment 175007 [details] Patch for landing
WebKit Review Bot
Comment 8 2012-11-19 11:23:34 PST
Comment on attachment 175007 [details] Patch for landing Clearing flags on attachment: 175007 Committed r135180: <http://trac.webkit.org/changeset/135180>
WebKit Review Bot
Comment 9 2012-11-19 11:23:39 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 10 2012-11-19 11:57:44 PST
Re-opened since this is blocked by bug 102700
Dana Jansens
Comment 12 2012-11-19 16:57:58 PST
Comment on attachment 175007 [details] Patch for landing ui/compositor is fixed now. Chrome for ChromeOS is building locally. Let's try again.
WebKit Review Bot
Comment 13 2012-11-19 17:22:55 PST
Comment on attachment 175007 [details] Patch for landing Clearing flags on attachment: 175007 Committed r135216: <http://trac.webkit.org/changeset/135216>
WebKit Review Bot
Comment 14 2012-11-19 17:22:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.