Summary: | [chromium] Remove the WebCompositorSupport virtual methods from the base class | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dana Jansens <danakj> | ||||||
Component: | New Bugs | Assignee: | Dana Jansens <danakj> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | backer, dglazkov, jamesr, peter+ews, piman, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 101968, 102700 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Dana Jansens
2012-11-13 16:38:13 PST
Created attachment 174025 [details]
Patch
This also depends on https://codereview.chromium.org/11410075 Comment on attachment 174025 [details] Patch Attachment 174025 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14831207 Comment on attachment 174025 [details] Patch Attachment 174025 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14826483 Once chromium rolls into WebKit, this'll be ready to land. Can I get a review please? Comment on attachment 174025 [details] Patch Rejecting attachment 174025 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /chromium/tests/LinkHighlightTest.o Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp: In constructor '<unnamed>::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest()': Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp:63: error: 'class WebKit::WebCompositorSupport' has no member named 'setAcceleratedAnimationEnabled' make: *** [out/Release/obj.target/webkit_unit_tests/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/14899255 Created attachment 175007 [details]
Patch for landing
Comment on attachment 175007 [details] Patch for landing Clearing flags on attachment: 175007 Committed r135180: <http://trac.webkit.org/changeset/135180> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 102700 Comment on attachment 175007 [details]
Patch for landing
ui/compositor is fixed now. Chrome for ChromeOS is building locally. Let's try again.
Comment on attachment 175007 [details] Patch for landing Clearing flags on attachment: 175007 Committed r135216: <http://trac.webkit.org/changeset/135216> All reviewed patches have been landed. Closing bug. |