Bug 102132

Summary:

Update DOMException name: NoDataAllowedError

Product:

WebKit

Reporter:

Erik Arvidsson <arv>

Component:

New Bugs

Assignee:

Erik Arvidsson <arv>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

101606

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none

Erik Arvidsson

Reported 2012-11-13 13:54:59 PST

Update DOMException name: NoDataAllowedError

Attachments
Patch (2.53 KB, patch) 2012-11-13 13:57 PST, Erik Arvidsson	no flags	Details Formatted Diff Diff
Patch for landing (2.83 KB, patch) 2012-11-14 07:00 PST, Erik Arvidsson	no flags	Details Formatted Diff Diff
Patch for landing (2.89 KB, patch) 2012-11-14 07:27 PST, Erik Arvidsson	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Erik Arvidsson

Comment 1 2012-11-13 13:57:06 PST

Created attachment 173980 [details] Patch

Darin Adler

Comment 2 2012-11-13 17:39:50 PST

Comment on attachment 173980 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173980&action=review > Source/WebCore/dom/ExceptionCode.h:39 > + NO_DATA_ALLOWED_ERR = 6, // Historical That’s a confusing comment. "Not used in any spec or in our code" would be a better comment. And we should consider removing the constant entirely at some point.

Erik Arvidsson

Comment 3 2012-11-14 07:00:30 PST

Created attachment 174149 [details] Patch for landing

Erik Arvidsson

Comment 4 2012-11-14 07:00:52 PST

(In reply to comment #2) > (From update of attachment 173980 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173980&action=review > > > Source/WebCore/dom/ExceptionCode.h:39 > > + NO_DATA_ALLOWED_ERR = 6, // Historical > > That’s a confusing comment. "Not used in any spec or in our code" would be a better comment. And we should consider removing the constant entirely at some point. That is the terminology used in the spec. I'll compromise and a comment before the enum explaining this.

WebKit Review Bot

Comment 5 2012-11-14 07:04:52 PST

Comment on attachment 174149 [details] Patch for landing Rejecting attachment 174149 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 1 cwd: /mnt/git/webkit-commit-queue Parsed 3 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/dom/DOMCoreException.cpp Hunk #1 FAILED at 40. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/DOMCoreException.cpp.rej patching file Source/WebCore/dom/ExceptionCode.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14833315

Erik Arvidsson

Comment 6 2012-11-14 07:27:09 PST

Created attachment 174154 [details] Patch for landing

WebKit Review Bot

Comment 7 2012-11-14 07:56:20 PST

Comment on attachment 174154 [details] Patch for landing Clearing flags on attachment: 174154 Committed r134610: <http://trac.webkit.org/changeset/134610>

WebKit Review Bot

Comment 8 2012-11-14 07:56:23 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.