Bug 102017

Summary:

DFG CreateThis should be able to statically account for the structure of the object it creates, if profiling indicates that this structure is always the same

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

102016, 102047, 102062

Bug Blocks:

Attachments:

Description	Flags
work in progress	none
the patch	ggaren: review-
the patch	ggaren: review+

Filip Pizlo

Reported 2012-11-12 17:20:17 PST

I will hack this up after https://bugs.webkit.org/show_bug.cgi?id=102016 lands.

Attachments
work in progress (12.77 KB, patch) 2012-11-13 01:11 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (21.55 KB, patch) 2012-11-13 14:01 PST, Filip Pizlo	ggaren: review-	Details Formatted Diff Diff
the patch (21.99 KB, patch) 2012-11-13 14:41 PST, Filip Pizlo	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2012-11-13 01:11:37 PST

Created attachment 173848 [details] work in progress

Filip Pizlo

Comment 2 2012-11-13 14:01:23 PST

Created attachment 173981 [details] the patch

Geoffrey Garen

Comment 3 2012-11-13 14:09:21 PST

Comment on attachment 173981 [details] the patch I think you missed a clear inside defineOwnProperty().

Filip Pizlo

Comment 4 2012-11-13 14:14:39 PST

(In reply to comment #3) > (From update of attachment 173981 [details]) > I think you missed a clear inside defineOwnProperty(). Good catch! Will fix.

Filip Pizlo

Comment 5 2012-11-13 14:41:13 PST

Created attachment 173992 [details] the patch

Geoffrey Garen

Comment 6 2012-11-13 14:49:40 PST

Comment on attachment 173992 [details] the patch r=me

Filip Pizlo

Comment 7 2012-11-13 23:27:56 PST

Landed in http://trac.webkit.org/changeset/134555

Note You need to log in before you can comment on or make changes to this bug.