Bug 102016

Summary: The act of getting the callee during 'this' construction should be explicit in bytecode
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 102017, 102047    
Attachments:
Description Flags
the patch msaboff: review+

Filip Pizlo
Reported 2012-11-12 17:13:50 PST
This will allow us to profile the callee.
Attachments
the patch (11.39 KB, patch)
2012-11-12 17:20 PST, Filip Pizlo 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-11-12 17:20:46 PST
Created attachment 173768 [details] the patch
WebKit Review Bot
Comment 2 2012-11-12 17:26:25 PST
Attachment 173768 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:462: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:465: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Saboff
Comment 3 2012-11-12 17:30:47 PST
Comment on attachment 173768 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=173768&action=review r=me > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:-2127 > - set(currentInstruction[1].u.operand, addToGraph(CreateThis, get(JSStack::Callee))); Check and remove other magic from get(JSStack::Callee) prior change.
Filip Pizlo
Comment 4 2012-11-12 22:06:03 PST
Landed in http://trac.webkit.org/changeset/134361
Note You need to log in before you can comment on or make changes to this bug.