Bug 101968

Summary:

[chromium] Stop using the WebCompositorSupport methods for changing settings

Product:

WebKit

Reporter:

Dana Jansens <danakj>

Component:

New Bugs

Assignee:

Dana Jansens <danakj>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, backer, cc-bugs, dglazkov, enne, fishd, jamesr, piman, tkent+wkapi, vollick, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

102146

Bug Blocks:

102153

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Dana Jansens

Reported 2012-11-12 12:47:11 PST

[chromium] Remove the WebCompositorSupport methods for changing settings, plumb everything through WebLayerTreeSettings

Attachments
Patch (17.21 KB, patch) 2012-11-12 12:56 PST, Dana Jansens	no flags	Details Formatted Diff Diff
Patch (16.38 KB, patch) 2012-11-12 13:56 PST, Dana Jansens	no flags	Details Formatted Diff Diff
Patch (2.86 KB, patch) 2012-11-13 16:31 PST, Dana Jansens	no flags	Details Formatted Diff Diff
Patch (2.68 KB, patch) 2012-11-15 08:26 PST, Dana Jansens	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Dana Jansens

Comment 1 2012-11-12 12:56:36 PST

Created attachment 173695 [details] Patch

WebKit Review Bot

Comment 2 2012-11-12 12:58:06 PST

Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

Dana Jansens

Comment 3 2012-11-12 13:56:24 PST

Created attachment 173717 [details] Patch rebased

James Robinson

Comment 4 2012-11-12 14:47:55 PST

Comment on attachment 173717 [details] Patch Yes!

WebKit Review Bot

Comment 5 2012-11-12 18:57:57 PST

Comment on attachment 173717 [details] Patch Rejecting attachment 173717 [details] from commit-queue. New failing tests: compositing/reflections/animation-inside-reflection.html animations/matrix-anim.html animations/3d/matrix-transform-type-animation.html animations/change-transform-style-during-animation.html animations/3d/state-at-end-event-transform.html animations/big-rotation.html animations/additive-transform-animations.html animations/3d/replace-filling-transform.html animations/fill-mode-transform.html compositing/animation/state-at-end-event-transform-layer.html animations/animation-start-event-destroy-renderer.html compositing/animation/animation-compositing.html compositing/layer-creation/overlap-animation.html animations/animation-hit-test-transform.html animations/3d/change-transform-in-end-event.html animations/animation-direction-reverse-hardware.html animations/keyframe-timing-functions-transform.html animations/animation-matrix-negative-scale-unmatrix.html animations/3d/transform-perspective.html animations/animation-end-event-destroy-renderer.html animations/animation-direction-normal.html animations/combo-transform-rotate+scale.html animations/3d/transform-origin-vs-functions.html animations/animation-direction-reverse.html animations/animation-iteration-event-destroy-renderer.html animations/animation-direction-reverse-fill-mode-hardware.html animations/dynamic-stylesheet-loading.html animations/combo-transform-translate+scale.html animations/animation-direction-reverse-timing-functions-hardware.html compositing/reflections/nested-reflection-animated.html Full output: http://queues.webkit.org/results/14817427

Dana Jansens

Comment 6 2012-11-12 19:00:40 PST

evidently we do use accelerated animation in tests?

vollick

Comment 7 2012-11-12 20:43:03 PST

(In reply to comment #6) > evidently we do use accelerated animation in tests? It looks like this change may accidentally enable accelerated animation. I would expect timeouts as a symptom of that.

WebKit Review Bot

Comment 8 2012-11-13 01:44:33 PST

Comment on attachment 173717 [details] Patch Attachment 173717 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14811751 New failing tests: compositing/reflections/animation-inside-reflection.html animations/animation-direction-reverse.html animations/3d/matrix-transform-type-animation.html animations/change-transform-style-during-animation.html animations/3d/state-at-end-event-transform.html animations/big-rotation.html animations/additive-transform-animations.html animations/3d/replace-filling-transform.html animations/fill-mode-transform.html compositing/animation/state-at-end-event-transform-layer.html animations/animation-start-event-destroy-renderer.html compositing/animation/animation-compositing.html compositing/layer-creation/overlap-animation.html animations/animation-hit-test-transform.html animations/3d/change-transform-in-end-event.html animations/animation-direction-reverse-hardware.html animations/keyframe-timing-functions-transform.html animations/animation-matrix-negative-scale-unmatrix.html animations/missing-from-to-transforms.html animations/3d/transform-perspective.html animations/animation-end-event-destroy-renderer.html animations/animation-direction-normal.html animations/combo-transform-rotate+scale.html animations/3d/transform-origin-vs-functions.html animations/matrix-anim.html animations/animation-iteration-event-destroy-renderer.html animations/animation-direction-reverse-fill-mode-hardware.html animations/dynamic-stylesheet-loading.html animations/animation-direction-reverse-timing-functions-hardware.html compositing/reflections/nested-reflection-animated.html

Dimitri Glazkov (Google)

Comment 9 2012-11-13 14:32:27 PST

Reverted r134446 for reason: Need to try a different strategy for landing a two-sided patch (3/3). Committed r134486: <http://trac.webkit.org/changeset/134486>

Dana Jansens

Comment 10 2012-11-13 16:31:53 PST

Created attachment 174023 [details] Patch

Dana Jansens

Comment 11 2012-11-13 16:32:25 PST

This now also depends on https://codereview.chromium.org/11361223/

WebKit Review Bot

Comment 12 2012-11-13 21:53:50 PST

Comment on attachment 174023 [details] Patch Attachment 174023 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14832220 New failing tests: compositing/reflections/animation-inside-reflection.html animations/matrix-anim.html animations/3d/matrix-transform-type-animation.html animations/change-transform-style-during-animation.html animations/3d/state-at-end-event-transform.html animations/big-rotation.html animations/additive-transform-animations.html animations/3d/replace-filling-transform.html animations/fill-mode-transform.html compositing/animation/state-at-end-event-transform-layer.html animations/animation-start-event-destroy-renderer.html compositing/animation/animation-compositing.html compositing/layer-creation/overlap-animation.html animations/animation-hit-test-transform.html animations/3d/change-transform-in-end-event.html animations/animation-direction-reverse-hardware.html animations/keyframe-timing-functions-transform.html animations/3d/transform-perspective.html animations/animation-end-event-destroy-renderer.html animations/animation-direction-normal.html animations/combo-transform-rotate+scale.html animations/3d/transform-origin-vs-functions.html animations/animation-direction-reverse.html animations/animation-iteration-event-destroy-renderer.html animations/animation-direction-reverse-fill-mode-hardware.html animations/dynamic-stylesheet-loading.html animations/combo-transform-translate+scale.html animations/animation-direction-reverse-timing-functions-hardware.html compositing/reflections/nested-reflection-animated.html

Dana Jansens

Comment 13 2012-11-15 08:26:53 PST

Created attachment 174453 [details] Patch rebase

Dana Jansens

Comment 14 2012-11-15 08:27:34 PST

This should be good to review/land now.

WebKit Review Bot

Comment 15 2012-11-15 16:18:30 PST

Comment on attachment 174453 [details] Patch Clearing flags on attachment: 174453 Committed r134850: <http://trac.webkit.org/changeset/134850>

WebKit Review Bot

Comment 16 2012-11-15 16:18:35 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.