Bug 101762

Summary: [EFL] Turn on errors on warnings for WebKit1 and WebKit2 libraries
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: WebKit EFLAssignee: KyungTae Kim <ktf.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, jinwoo7.song, ktf.kim, lucas.de.marchi, rakuco, ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 102038    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Laszlo Gombos
Reported 2012-11-09 07:54:26 PST
Introduce the following change and fix the resulting build failures... Index: Source/CMakeLists.txt IF (ENABLE_WEBKIT) - WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebKit_LIBRARY_NAME}) + WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebKit_LIBRARY_NAME} ${ADDITIONAL_FLAGS}) ENDIF () IF (ENABLE_WEBKIT2) - WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebKit2_LIBRARY_NAME}) + WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebKit2_LIBRARY_NAME} ${ADDITIONAL_FLAGS}) ENDIF ()
Attachments
Patch (1.37 KB, patch)
2012-11-12 04:42 PST, KyungTae Kim 		no flags
DetailsFormatted DiffDiff
Patch (1.38 KB, patch)
2012-11-12 21:40 PST, KyungTae Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2012-11-09 08:10:25 PST
Would be great to look into this as well. /build/WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::tile_w' may be used uninitialized in this function [-Wuninitialized] /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::w2_rel' may be used uninitialized in this function [-Wuninitialized]
KyungTae Kim
Comment 2 2012-11-12 01:46:28 PST
The 2 warnings are false alarms. In ewk_tiled_backing_store.cpp:1857, Eina_Tile_Grid_Slicer slicer is defined, and is initialized through eina_tile_grid_slicer_setup but eina_tile_grid_slicer_next doesn't know it is initialized. I wonder whether additional initialization is needed here for fixing build warning. WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x: In function 'bool ewk_tiled_backing_store_pre_render_region(Evas_Object*, Evas_Coord, Evas_Coord, Evas_Coord, Evas_Coord, float)': WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::tile_w' may be used uninitialized in this function [-Wuninitialized] Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1857:27: note: 'slicer._Eina_Tile_Grid_Slicer::tile_w' was declared here WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::w2_rel' may be used uninitialized in this function [-Wuninitialized] Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1857:27: note: 'slicer._Eina_Tile_Grid_Slicer::w2_rel' was declared here
KyungTae Kim
Comment 3 2012-11-12 04:42:57 PST
Created attachment 173619 [details] Patch
KyungTae Kim
Comment 4 2012-11-12 04:46:17 PST
Comment on attachment 173619 [details] Patch It can make build error on 32bit build bot until the 2 warnings issue (that warnings are only occurred on 32bit build bot now) is resolved.
Gyuyoung Kim
Comment 5 2012-11-12 21:26:54 PST
Comment on attachment 173619 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173619&action=review > ChangeLog:3 > + [EFL]Turn on errors on warnings for WebKit1 and WebKit2 libraries Add a space between [EFL] and Turn.
KyungTae Kim
Comment 6 2012-11-12 21:40:39 PST
Created attachment 173813 [details] Patch
WebKit Review Bot
Comment 7 2012-11-12 22:55:41 PST
Comment on attachment 173813 [details] Patch Clearing flags on attachment: 173813 Committed r134368: <http://trac.webkit.org/changeset/134368>
WebKit Review Bot
Comment 8 2012-11-12 22:55:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.