Bug 101737

Summary:

Web Inspector: Timeline: fix test expectations

Product:

WebKit

Reporter:

eustas.bug

Component:

Web Inspector (Deprecated)

Assignee:

eustas.bug

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, caseq, eustas.bug, keishi, loislo, ossy, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

eustas.bug

Reported 2012-11-09 03:15:15 PST

The expected order of timeline records of specific types has been changed: https://bugs.webkit.org/show_bug.cgi?id=101544 This change fixes test expectations.

Attachments
Patch (1.67 KB, patch) 2012-11-09 03:19 PST, eustas.bug	no flags	Details Formatted Diff Diff
Patch (2.62 KB, patch) 2012-11-09 04:34 PST, eustas.bug	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

eustas.bug

Comment 1 2012-11-09 03:19:16 PST

Created attachment 173255 [details] Patch

Yury Semikhatsky

Comment 2 2012-11-09 03:52:29 PST

Comment on attachment 173255 [details] Patch You may want to update TestExpectations as well.

eustas.bug

Comment 3 2012-11-09 04:24:03 PST

(In reply to comment #2) > (From update of attachment 173255 [details]) > You may want to update TestExpectations as well. OK. Test was marked as text-flaky on 03'Jul but reason wasn't specified.

eustas.bug

Comment 4 2012-11-09 04:34:26 PST

Created attachment 173264 [details] Patch

Yury Semikhatsky

Comment 5 2012-11-09 05:06:58 PST

(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 173255 [details] [details]) > > You may want to update TestExpectations as well. > > OK. > > Test was marked as text-flaky on 03'Jul but reason wasn't specified. What about Mac and Wind bots, does it pass there? If so then the expectations will be wrong for those platforms after this change.

eustas.bug

Comment 6 2012-11-09 05:22:23 PST

(In reply to comment #5) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 173255 [details] [details] [details]) > > > You may want to update TestExpectations as well. > > > > OK. > > > > Test was marked as text-flaky on 03'Jul but reason wasn't specified. > > What about Mac and Wind bots, does it pass there? If so then the expectations will be wrong for those platforms after this change. This expectations should work for all platforms. Before the change we got "Send Request" arriving in timeline before enclosing record. The tested scenario is: cause "send request", when data arrives, cause second "send request" from within notification event. So, before the change "send request" record arrived before second "function call" and before the first (notification) "event". That resulted the following sequence: function call, send request A ->, function call A, send request B ->, event B, event After change "send request" should arrive after enclosing record. As a result we get: function call, function call A, <- send request A, event B, <- send request B, event This order should be platform independent, because all events are explicitly chained (except first function call). I believe Mac and Win bots will be happy.

Csaba Osztrogonác

Comment 7 2012-11-12 04:40:31 PST

Comment on attachment 173264 [details] Patch Clearing flags on attachment: 173264 Committed r134212: <http://trac.webkit.org/changeset/134212>

Csaba Osztrogonác

Comment 8 2012-11-12 04:40:37 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.