Bug 101637

Summary: Remove ReadWriteLock
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, darin, hyatt, levin+threading, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
1st try none

Laszlo Gombos
Reported 2012-11-08 13:18:52 PST
It seems ReadWriteLock is not used and it is only implemented for some environments so it requires some #if maintenance. Perhaps we should remove it (or find some use for it).
Attachments
1st try (4.70 KB, patch)
2012-11-08 13:48 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2012-11-08 13:31:45 PST
A related discussion from 3 years ago suggests the possibility of removing this class as well - https://bugs.webkit.org/show_bug.cgi?id=30713#c4
Laszlo Gombos
Comment 2 2012-11-08 13:48:08 PST
Created attachment 173111 [details] 1st try
Darin Adler
Comment 3 2012-11-13 10:38:13 PST
Comment on attachment 173111 [details] 1st try Should be fine.
WebKit Review Bot
Comment 4 2012-11-19 15:47:58 PST
Comment on attachment 173111 [details] 1st try Clearing flags on attachment: 173111 Committed r135206: <http://trac.webkit.org/changeset/135206>
WebKit Review Bot
Comment 5 2012-11-19 15:48:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.