| Summary: | setAttributeNode and friends should not have optional argument | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Erik Arvidsson <arv> | ||||||
| Component: | New Bugs | Assignee: | Erik Arvidsson <arv> | ||||||
| Status: | REOPENED --- | ||||||||
| Severity: | Normal | CC: | abarth, cmarcelo, haraken, japhet, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 102118 | ||||||||
| Bug Blocks: | 101604 | ||||||||
| Attachments: |
|
||||||||
|
Description
Erik Arvidsson
2012-11-08 11:55:21 PST
Created attachment 173087 [details]
Patch
Comment on attachment 173087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173087&action=review > Source/WebCore/ChangeLog:9 > + Make the Attr argument to setAttributeNode etc mandatory. This allows us to remove > + some special case code that only exist in CodeGeneratorV8.pm. Removing some code from WebKit is not a meaningful rationale for a change that is observable from JavaScript. (In reply to comment #2) > (From update of attachment 173087 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173087&action=review > > > Source/WebCore/ChangeLog:9 > > + Make the Attr argument to setAttributeNode etc mandatory. This allows us to remove > > + some special case code that only exist in CodeGeneratorV8.pm. > > Removing some code from WebKit is not a meaningful rationale for a change that is observable from JavaScript. Let me update the ChangeLog. With this change we match the spec and we better match other browsers. Created attachment 173097 [details]
Patch
Comment on attachment 173097 [details] Patch Clearing flags on attachment: 173097 Committed r133944: <http://trac.webkit.org/changeset/133944> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 102118 |