Bug 101631

Summary: setAttributeNode and friends should not have optional argument
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: New BugsAssignee: Erik Arvidsson <arv>
Status: REOPENED    
Severity: Normal CC: abarth, cmarcelo, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 102118    
Bug Blocks: 101604    
Attachments:
Description Flags
Patch
none
Patch none

Erik Arvidsson
Reported 2012-11-08 11:55:21 PST
setAttributeNode and friends should not have optional argument
Attachments
Patch (10.84 KB, patch)
2012-11-08 11:59 PST, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Patch (10.94 KB, patch)
2012-11-08 12:40 PST, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Erik Arvidsson
Comment 1 2012-11-08 11:59:52 PST
Created attachment 173087 [details] Patch
Alexey Proskuryakov
Comment 2 2012-11-08 12:29:13 PST
Comment on attachment 173087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173087&action=review > Source/WebCore/ChangeLog:9 > + Make the Attr argument to setAttributeNode etc mandatory. This allows us to remove > + some special case code that only exist in CodeGeneratorV8.pm. Removing some code from WebKit is not a meaningful rationale for a change that is observable from JavaScript.
Erik Arvidsson
Comment 3 2012-11-08 12:32:36 PST
(In reply to comment #2) > (From update of attachment 173087 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173087&action=review > > > Source/WebCore/ChangeLog:9 > > + Make the Attr argument to setAttributeNode etc mandatory. This allows us to remove > > + some special case code that only exist in CodeGeneratorV8.pm. > > Removing some code from WebKit is not a meaningful rationale for a change that is observable from JavaScript. Let me update the ChangeLog. With this change we match the spec and we better match other browsers.
Erik Arvidsson
Comment 4 2012-11-08 12:40:14 PST
Created attachment 173097 [details] Patch
WebKit Review Bot
Comment 5 2012-11-08 13:52:44 PST
Comment on attachment 173097 [details] Patch Clearing flags on attachment: 173097 Committed r133944: <http://trac.webkit.org/changeset/133944>
WebKit Review Bot
Comment 6 2012-11-08 13:52:47 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2012-11-13 12:06:59 PST
Re-opened since this is blocked by bug 102118
Note You need to log in before you can comment on or make changes to this bug.