Bug 101544

Summary: Web Inspector: Timeline: "Send Request" events are shown out of order.
Product: WebKit Reporter: eustas.bug
Component: Web Inspector (Deprecated)Assignee: eustas.bug
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, caseq, eustas.bug, jbadics, keishi, loislo, ossy, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Out-of-order records
none
Patch
none
Patch none

eustas.bug
Reported 2012-11-07 22:06:53 PST
Created attachment 172932 [details] Out-of-order records Historically "Send Request" records are pushed out of order to make them top-level. Nowadays frontend is responsible for changing parent of records. Replacing backend out-of-order pushing with frontend reparenting makes record appear in-order.
Attachments
Out-of-order records (55.32 KB, image/png)
2012-11-07 22:06 PST, eustas.bug 		no flags
Details
Patch (3.51 KB, patch)
2012-11-07 22:13 PST, eustas.bug 		no flags
DetailsFormatted DiffDiff
Patch (5.49 KB, patch)
2012-11-08 01:40 PST, eustas.bug 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
eustas.bug
Comment 1 2012-11-07 22:13:46 PST
Created attachment 172933 [details] Patch
Yury Semikhatsky
Comment 2 2012-11-07 23:17:23 PST
Comment on attachment 172933 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172933&action=review > Source/WebCore/ChangeLog:8 > + Solution: replace obsolete out-of-order record pushing with forntend Can we test this in layout tests?
eustas.bug
Comment 3 2012-11-08 01:38:31 PST
Comment on attachment 172933 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172933&action=review >> Source/WebCore/ChangeLog:8 >> + Solution: replace obsolete out-of-order record pushing with forntend > > Can we test this in layout tests? Done
eustas.bug
Comment 4 2012-11-08 01:40:01 PST
Created attachment 172960 [details] Patch
WebKit Review Bot
Comment 5 2012-11-08 09:05:54 PST
Comment on attachment 172960 [details] Patch Rejecting attachment 172960 [details] from commit-queue. New failing tests: fast/repaint/selection-after-delete.html Full output: http://queues.webkit.org/results/14775142
WebKit Review Bot
Comment 6 2012-11-08 23:46:22 PST
Comment on attachment 172960 [details] Patch Clearing flags on attachment: 172960 Committed r134023: <http://trac.webkit.org/changeset/134023>
WebKit Review Bot
Comment 7 2012-11-08 23:46:25 PST
All reviewed patches have been landed. Closing bug.
János Badics
Comment 8 2012-11-09 01:07:52 PST
This modification caused a test (inspector/timeline/timeline-receive-response-event.html) fail on Qt with the following diff: --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/timeline/timeline-receive-response-event-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/timeline/timeline-receive-response-event-actual.txt @@ -1,10 +1,6 @@ Tests the Timeline API instrumentation of a SendRequest, ReceiveResponse etc. FunctionCall -ResourceSendRequest - ResourceReceiveResponse - ResourceReceivedData - ResourceFinish FunctionCall ResourceSendRequest ResourceReceiveResponse @@ -12,6 +8,10 @@ ResourceFinish EventDispatch FunctionCall +ResourceSendRequest + ResourceReceiveResponse + ResourceReceivedData + ResourceFinish EventDispatch FunctionCall I'm not sure if it's a correct result or not; is it a problem if this part of code is written at different line number?
Csaba Osztrogonác
Comment 9 2012-11-12 03:42:13 PST
Unfortunately we don't know what happens on other ports, because this test is skipped on all ports because of different reason.
eustas.bug
Comment 10 2012-11-12 03:47:48 PST
(In reply to comment #9) > Unfortunately we don't know what happens on other ports, because > this test is skipped on all ports because of different reason. I've fixed test: https://bugs.webkit.org/show_bug.cgi?id=101737
Note You need to log in before you can comment on or make changes to this bug.