Bug 101532

Summary: [Qt][CSS Shaders] Make custom filter render in Wk1 mode
Product: WebKit Reporter: Alexandru Chiculita <achicu>
Component: Layout and RenderingAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alexandru Chiculita
Reported 2012-11-07 17:52:11 PST
Currently, there's no way to enable custom filters in Wk1 mode. Also, it looks like WebGL fails to instantiate when running in that mode.
Attachments
Patch (6.43 KB, patch)
2013-01-14 10:24 PST, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2013-01-14 01:55:37 PST
They are enabled by default when WebGL is enabled. They do however fail or cause crashes because BitmapTextureImageBuffer::applyFilter tries to build the FilterEffectRenderer without a Document pointer.
Allan Sandfeld Jensen
Comment 2 2013-01-14 09:09:29 PST
(In reply to comment #1) > They are enabled by default when WebGL is enabled. They do however fail or cause crashes because BitmapTextureImageBuffer::applyFilter tries to build the FilterEffectRenderer without a Document pointer. That is bug #106796, but only applies when non-GL TextureMapper is used. There is also a problem even with the GL TextureMapper.
Allan Sandfeld Jensen
Comment 3 2013-01-14 10:24:04 PST
Created attachment 182598 [details] Patch
WebKit Review Bot
Comment 4 2013-01-15 02:03:24 PST
Comment on attachment 182598 [details] Patch Clearing flags on attachment: 182598 Committed r139731: <http://trac.webkit.org/changeset/139731>
WebKit Review Bot
Comment 5 2013-01-15 02:03:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.