Summary: | [Meta] BaseDateAndTimeInputType should not inherit from TextFieldInputType | ||
---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> |
Component: | Forms | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | aberent, jonlee, morrita, olilan |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | 100910, 101007, 101031, 101038, 101039, 101196, 101722, 101886, 106306 | ||
Bug Blocks: | 29359 |
Description
Kent Tamura
2012-11-01 02:35:32 PDT
Implementation of Date/time input types in Chromium-Android is hacky. We intercepts input events for the input types at outside of WebKit, and opens date/time pickers provided by Android system. I guess iOS uses a similar way. WebCore has interfaces to handle date/time chooser; ChromeClient::openDateTimeChooser, DateTimeChooser, and DateTimeChooserClient. * Date/time types are not textfields essentially. BaseDateAndTimeInputType should stop inheriting from TextFieldInputType. It wastes memory. A text block with -webkit-appearance:menulist would be enough. * Use the existing date/time chooser interfaces, and stop the hack in Chromium-Android. So we are going to eliminate text fields in such input elements for some platforms like Android, right? That sounds reasonable change. Completed all of changes. |